Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133677: Skip test intest_httpservers if not utf-8#133706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIrelandStanFromIreland commentedMay 8, 2025•
edited by bedevere-appbot
Loading

@bedevere-appbedevere-appbot added the testsTests in the Lib/test dir labelMay 8, 2025
@StanFromIreland
Copy link
ContributorAuthor

Calling the raspbian buildbots would verify this is solved.

@sharktide
Copy link
Contributor

sharktide commentedMay 8, 2025•
edited
Loading

@StanFromIreland Is it okay if I handle the zipfile test fail? I worked alot with the zipfile lib

@ZeroIntensity
Copy link
Member

!buildbot raspbian

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@ZeroIntensity for commite45a58d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133706%2Fmerge

The command will test the builders whose names match following regular expression:raspbian

The builders matched are:

  • ARM64 Raspbian PR
  • ARM Raspbian PR

@StanFromIreland
Copy link
ContributorAuthor

Test passes on buildbot.

def test_undecodable_parameter(self):
# sanity check using a valid parameter
response = self.request(self.base_url + '/?x=123').read()
self.assertRegex(response, rf'listing for {self.base_url}/\?x=123'.encode('latin1'))
# now the bogus encoding
# now the bogus(utf-8)encoding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Comment should be reverted as well.

@sharktide
Copy link
Contributor

@zware please review#133715 since it directly correlates to this PR

@serhiy-storchaka
Copy link
Member

Sorry, but skipping the test is not a proper fix of this issue. Test failure exposes a bug inhttp.server.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@zwarezwareAwaiting requested review from zware

Assignees
No one assigned
Labels
awaiting reviewskip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@StanFromIreland@sharktide@ZeroIntensity@bedevere-bot@serhiy-storchaka@zware
[8]ページ先頭
©2009-2025 Movatter.jp