Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix inconsistent set ordering in annotations (GH-133682)#133702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

akshat62
Copy link
Contributor

@akshat62akshat62 commentedMay 8, 2025•
edited by bedevere-appbot
Loading

@python-cla-bot
Copy link

python-cla-botbot commentedMay 8, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@akshat62akshat62 marked this pull request as draftMay 8, 2025 19:22
@akshat62akshat62 marked this pull request as ready for reviewMay 8, 2025 19:33
@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@akshat62akshat62 marked this pull request as ready for reviewMay 8, 2025 20:09
@akshat62akshat62 requested a review fromterryjreedyMay 8, 2025 20:10
@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@akshat62
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-app
Copy link

Thanks for making the requested changes!

@JelleZijlstra: please review the changes made to this pull request.

@methanemethane removed their request for reviewMay 9, 2025 04:14
@akshat62
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-app
Copy link

Thanks for making the requested changes!

@JelleZijlstra: please review the changes made to this pull request.

@akshat62
Copy link
ContributorAuthor

How to re-trigger failing checks ?

@JelleZijlstraJelleZijlstra added the needs backport to 3.14bugs and security fixes labelMay 9, 2025
@JelleZijlstraJelleZijlstra merged commita2a0fa9 intopython:mainMay 9, 2025
44 of 45 checks passed
@miss-islington-app
Copy link

Thanks@akshat62 for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 9, 2025
…ythonGH-133702)(cherry picked from commita2a0fa9)Co-authored-by: Akshat Gupta <akshat.gupta24@gmail.com>
@bedevere-app
Copy link

GH-133754 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 9, 2025
JelleZijlstra pushed a commit that referenced this pull requestMay 9, 2025
…GH-133702) (#133754)gh-133682: Fix inconsistent set ordering in annotationlib test (GH-133702)(cherry picked from commita2a0fa9)Co-authored-by: Akshat Gupta <akshat.gupta24@gmail.com>
@akshat62akshat62 deleted the issue-133682-fix-set-ordering branchMay 9, 2025 16:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@pfmoorepfmooreAwaiting requested review from pfmoore

@pradyunsgpradyunsgAwaiting requested review from pradyunsg

@markshannonmarkshannonAwaiting requested review from markshannon

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melotti

@hugovkhugovkAwaiting requested review from hugovk

@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner

@terryjreedyterryjreedyAwaiting requested review from terryjreedy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@akshat62@JelleZijlstra@terryjreedy
[8]ページ先頭
©2009-2025 Movatter.jp