Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-132983: Remove subclassing support from zstd types#133694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 1 commit intopython:mainfromAA-Turner:zstd-no-subclass
May 8, 2025

Conversation

AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commentedMay 8, 2025•
edited
Loading

cc@Rogdham

For what it's worth,bz2 andlzma's decompressor subclassing fail on creation:

>>>import bz2>>>classD(bz2.BZ2Decompressor):pass... Traceback (most recent call last):  File "<python-input-18>", line 1, in <module>    class D(bz2.BZ2Decompressor): passTypeError: type '_bz2.BZ2Decompressor' is not an acceptable base type>>>import lzma>>>classD(lzma.LZMADecompressor):pass... Traceback (most recent call last):  File "<python-input-19>", line 1, in <module>    class D(lzma.LZMADecompressor): passTypeError: type '_lzma.LZMADecompressor' is not an acceptable base type

Copy link
Contributor

@RogdhamRogdham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, I also confirmed it works as intended.

I just noticed the case difference betweenzstdcompressor_type_spec andZstdDecompressor_type_spec (and same for…_slots), but maybe it's for an other PR?

@AA-Turner
Copy link
MemberAuthor

See#133674, which does the rename.

Rogdham reacted with thumbs up emoji

@AA-TurnerAA-Turnerenabled auto-merge (squash)May 8, 2025 18:24
@AA-TurnerAA-Turner merged commitbd7c585 intopython:mainMay 8, 2025
42 checks passed
@AA-TurnerAA-Turner added the needs backport to 3.14bugs and security fixes labelMay 9, 2025
@miss-islington-app
Copy link

Thanks@AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 9, 2025
…-133694)For consistency with ``bz2``, ``lzma``, and ``zlib``.(cherry picked from commitbd7c585)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

GH-133762 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 9, 2025
AA-Turner added a commit that referenced this pull requestMay 9, 2025
…) (#133762)GH-132983: Remove subclassing support from zstd types (GH-133694)For consistency with ``bz2``, ``lzma``, and ``zlib``.(cherry picked from commitbd7c585)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@RogdhamRogdhamRogdham approved these changes

@emmatypingemmatypingAwaiting requested review from emmatyping

@picnixzpicnixzAwaiting requested review from picnixz

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@AA-Turner@Rogdham
[8]ページ先頭
©2009-2025 Movatter.jp