NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

[3.13] gh-132762: Fix underallocation bug in`dict.fromkeys()`(gh-133627)#133686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

colesbury merged 1 commit intopython:3.13fromcolesbury:backport-421ba58-3.13

May 8, 2025

Merged

[3.13] gh-132762: Fix underallocation bug in`dict.fromkeys()`(gh-133627)#133686

colesbury merged 1 commit intopython:3.13fromcolesbury:backport-421ba58-3.13

May 8, 2025

Conversation

Copy link

Contributor

colesbury commentedMay 8, 2025•
edited by bedevere-appbot
Loading

The functiondict_set_fromkeys() adds elements of a set to an existing dictionary. The size of the expanded dictionary was estimated withPySet_GET_SIZE(iterable), which did not take into account the size of the existing dictionary.
(cherry picked from commit421ba58)

Issue:dict_set_fromkeys() calculates size of dictionary improperly #132762

[3.13]pythongh-132762: Fix underallocation bug indict.fromkeys()(p…

796c88b

…ythongh-133627)The function `dict_set_fromkeys()` adds elements of a set to an existingdictionary. The size of the expanded dictionary was estimated with`PySet_GET_SIZE(iterable)`, which did not take into account the size of theexisting dictionary.(cherry picked from commit421ba58)Co-authored-by: Angela Liss <59097311+angela-tarantula@users.noreply.github.com>