Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133656: Remove deprecatedzipimport.zipimporter.load_module#133662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Wulian233 wants to merge5 commits intopython:main
base:main
Choose a base branch
Loading
fromWulian233:zipimporter

Conversation

Wulian233
Copy link
Contributor

@Wulian233Wulian233 commentedMay 8, 2025•
edited
Loading

@sharktide
Copy link
Contributor

@Wulian233

considering how pyhton imports work, You might have to modify the files that run on import or any references to load_module. This will be a really daunting task for you :( sorry!

Comment on lines 99 to 111

* :mod:`zipimport`:

* :meth:`~zipimport.zipimporter.load_module` has been deprecated since
Python 3.10. Use :meth:`~zipimport.zipimporter.exec_module` instead.
(Contributed by Jiahao Li in :gh:`125746`.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Same issue again@hugovk, do we keep these? This should be in the devguide.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I saw that others did it this way recently.#133876

I remember that before it was directly removed👀

Okay, I will modify this after a few hours

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

First, we shouldn't include thepending-removal-in-X.Y.rst file in X.Y'sdeprecations/index.rst, there's no point showing it there.

Given that, is it easier to leave the contents as is (fixing warnings where necessary), for when we want to backport changes to older branches?

@sharktide
Copy link
Contributor

@Wulian233 Will review tmrw

Copy link
Contributor

@sharktidesharktide left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR seems sound, however I'll approve it afterstanfromireland andhugovk resolve their conversation, because I am not sure either if it should or shouldn't be in the devguide either :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk left review comments

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@sharktidesharktidesharktide left review comments

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Wulian233@sharktide@hugovk@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp