Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133581: Improve AST unparsing of t-strings#133635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 5 commits intopython:mainfromJelleZijlstra:tstr-round
May 8, 2025

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commentedMay 8, 2025•
edited by bedevere-appbot
Loading

Fix unparsing of empty t-strings, and use the string value in unparsing interpolations.

Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thanks@JelleZijlstra! Let's backport this to 3.14 as well.

@lysnikolaoulysnikolaou added the needs backport to 3.14bugs and security fixes labelMay 8, 2025
@JelleZijlstraJelleZijlstra merged commitbfac7d2 intopython:mainMay 8, 2025
45 checks passed
@miss-islington-app
Copy link

Thanks@JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 8, 2025
(cherry picked from commitbfac7d2)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app
Copy link

GH-133666 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 8, 2025
@JelleZijlstraJelleZijlstra deleted the tstr-round branchMay 8, 2025 13:36
JelleZijlstra added a commit that referenced this pull requestMay 8, 2025
…3666)gh-133581: Improve AST unparsing of t-strings (GH-133635)(cherry picked from commitbfac7d2)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@nascheme
Copy link
Member

Looks like some refleak buildbots started failing after this.

https://buildbot.python.org/#/builders/1735/builds/6

test.test_future_stmt.test_future leaked [28, 28, 28] references, sum=84test.test_future_stmt.test_future leaked [84, 84, 84] memory blocks, sum=252Re-running test.test_future_stmt.test_future in verbose modetest.test_future_stmt.test_future leaked [28, 28, 28] references, sum=84test.test_future_stmt.test_future leaked [84, 84, 84] memory blocks, sum=252

@nascheme
Copy link
Member

Yup, it bisects to this commit on the 3.14 branch:

commit 153496921a05e205d4c45c4a64888ccd43148897 (HEAD)Author: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>Date:   Thu May 8 15:40:44 2025 +0200    [3.14] gh-133581: Improve AST unparsing of t-strings (GH-133635) (#133666

@JelleZijlstra
Copy link
MemberAuthor

Thanks for flagging, I'll investigate. Must be one of the changes inast_unparse.c but from staring at the code I don't see anything wrong yet.

@JelleZijlstra
Copy link
MemberAuthor

Fix in#133724. The issue was in the existing code, it just wasn't tested before.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lysnikolaoulysnikolaoulysnikolaou approved these changes

@isidenticalisidenticalAwaiting requested review from isidenticalisidentical is a code owner

@Eclips4Eclips4Awaiting requested review from Eclips4Eclips4 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JelleZijlstra@nascheme@lysnikolaou
[8]ページ先頭
©2009-2025 Movatter.jp