Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133610: Remove PyUnicode_AsDecoded/Encoded functions#133612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 8 commits intopython:mainfromStanFromIreland:rem-depr-uni-c-api
May 9, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIrelandStanFromIreland commentedMay 7, 2025•
edited by bedevere-appbot
Loading

@StanFromIrelandStanFromIreland changed the titleRemove PyUnicode_AsDecoded/Encoded functionsgh-133610: Remove PyUnicode_AsDecoded/Encoded functionsMay 7, 2025
@StanFromIreland
Copy link
ContributorAuthor

StanFromIreland commentedMay 8, 2025•
edited
Loading

@StanFromIreland
Copy link
ContributorAuthor

Request:@vstinner

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@vstinner
Copy link
Member

Tests / Ubuntu (free-threading) / build and test (ubuntu-24.04) (pull_request)

test_zstd crash:

0:12:55 load avg: 14.73 [1/3/1] test_zstd worker non-zero exit code (Exit code -11 (SIGSEGV))Re-running test_zstd in verbose mode (matching: test_compress_locking)test_compress_locking (test.test_zstd.FreeThreadingMethodTests.test_compress_locking) ...Fatal Python error: Fatal Python error: Segmentation faultSegmentation fault

@vstinner
Copy link
Member

A code search on PyPI top 8,000 projects found 2 projects, but there are only references to these 4 removed functions, these functions are not actually used. So we should be good in terms of impact.

StanFromIreland reacted with thumbs up emoji

@vstinnervstinner merged commit4fd1095 intopython:mainMay 9, 2025
43 checks passed
@StanFromIrelandStanFromIreland deleted the rem-depr-uni-c-api branchMay 9, 2025 15:33
@emmatyping
Copy link
Member

emmatyping commentedMay 9, 2025•
edited
Loading

@vstinner@StanFromIreland the zstd crash is noted in#132983 (comment). I'm still trying to figure out the cause/fix for it.

vstinner reacted with eyes emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@encukouencukouAwaiting requested review from encukouencukou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@StanFromIreland@vstinner@emmatyping
[8]ページ先頭
©2009-2025 Movatter.jp