Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-133597: Fix memory leak if error occurred in _sys_getwindowsversion_from_kernel32#133598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-133597: Fix memory leak if error occurred in _sys_getwindowsversion_from_kernel32#133598
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I believe this PR may skip news. |
FYI, Sergey, the CI fails due to the recent beta(3.14b1) release. I'll restart it later. |
Thanks! Yeah, I saw a possible fix#133599 |
0ec8fc8
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@sergey-miryanov for the PR, and@zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…version_from_kernel32 (pythonGH-133598)(cherry picked from commit0ec8fc8)Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
…version_from_kernel32 (pythonGH-133598)(cherry picked from commit0ec8fc8)Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
GH-133659 is a backport of this pull request to the3.14 branch. |
GH-133660 is a backport of this pull request to the3.13 branch. |
bedevere-bot commentedMay 8, 2025
|
Uh oh!
There was an error while loading.Please reload this page.
If
GetFileVersionInfoW
orVerQueryValueW
fails inside_sys_getwindowsversion_from_kernel32
then allocatedverblock
not freed.