Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-133597: Fix memory leak if error occurred in _sys_getwindowsversion_from_kernel32#133598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

sergey-miryanov
Copy link
Contributor

@sergey-miryanovsergey-miryanov commentedMay 7, 2025
edited
Loading

IfGetFileVersionInfoW orVerQueryValueW fails inside_sys_getwindowsversion_from_kernel32 then allocatedverblock not freed.

@sergey-miryanov
Copy link
ContributorAuthor

I believe this PR may skip news.

@Eclips4
Copy link
Member

FYI, Sergey, the CI fails due to the recent beta(3.14b1) release. I'll restart it later.

sergey-miryanov reacted with heart emoji

@sergey-miryanov
Copy link
ContributorAuthor

Thanks! Yeah, I saw a possible fix#133599

Eclips4 reacted with thumbs up emoji

@Eclips4Eclips4 added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 7, 2025
@Eclips4Eclips4 requested a review fromzoobaMay 8, 2025 07:09
@zoobazooba merged commit0ec8fc8 intopython:mainMay 8, 2025
42 checks passed
@miss-islington-app
Copy link

Thanks@sergey-miryanov for the PR, and@zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 8, 2025
…version_from_kernel32 (pythonGH-133598)(cherry picked from commit0ec8fc8)Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 8, 2025
…version_from_kernel32 (pythonGH-133598)(cherry picked from commit0ec8fc8)Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
@bedevere-app
Copy link

GH-133659 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 8, 2025
@bedevere-app
Copy link

GH-133660 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 8, 2025
zooba pushed a commit that referenced this pull requestMay 8, 2025
…n_from_kernel32 (GH-133598)(cherry picked from commit0ec8fc8)Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
zooba pushed a commit that referenced this pull requestMay 8, 2025
…n_from_kernel32 (GH-133598)(cherry picked from commit0ec8fc8)Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Debian root 3.14 (tier-1) has failed when building commitcaeb422.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1742/builds/11) and take a look at the build logs.
  4. Check if the failure is related to this commit (caeb422) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1742/builds/11

Failed tests:

  • test_tokenize

Failed subtests:

  • test_random_files - test.test_tokenize.TestRoundtrip.test_random_files

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/root/buildarea/3.14.angelico-debian-amd64/build/Lib/test/test_tokenize.py", line2021, intest_random_filesself.check_roundtrip(f)~~~~~~~~~~~~~~~~~~~~^^^  File"/root/buildarea/3.14.angelico-debian-amd64/build/Lib/test/test_tokenize.py", line1869, incheck_roundtrip    untokenized_code= tokenize.untokenize(tokenize.tokenize(readline))  File"/root/buildarea/3.14.angelico-debian-amd64/build/Lib/tokenize.py", line341, inuntokenize    out= ut.untokenize(iterable)  File"/root/buildarea/3.14.angelico-debian-amd64/build/Lib/tokenize.py", line229, inuntokenizefor tin it:^^  File"/root/buildarea/3.14.angelico-debian-amd64/build/Lib/tokenize.py", line492, intokenizeyield from _generate_tokens_from_c_tokenizer(rl_gen.__next__, encoding,extra_tokens=True)  File"/root/buildarea/3.14.angelico-debian-amd64/build/Lib/tokenize.py", line583, in_generate_tokens_from_c_tokenizeryield TokenInfo._make(info)^^^^^^^^^^^^^^^AttributeError:type object 'TokenInfo' has no attribute '_tokenize'

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Eclips4Eclips4Eclips4 approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@zoobazoobaAwaiting requested review from zooba

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@sergey-miryanov@Eclips4@bedevere-bot@zooba@zware

[8]ページ先頭

©2009-2025 Movatter.jp