Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132983: Remove pyzstd in identifiers#133535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Rogdham
Copy link
Contributor

@RogdhamRogdham commentedMay 6, 2025•
edited by bedevere-appbot
Loading

The_PyZstd_xxx extern functions were leftover artifacts of the move from pyzstd to cpython.

I have renamed them to the_zstd_xxx convention used for private functions.

@python-cla-bot
Copy link

python-cla-botbot commentedMay 6, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@RogdhamRogdham marked this pull request as ready for reviewMay 6, 2025 20:04
@Rogdham
Copy link
ContributorAuthor

Thanks@emmatyping for the explanation about the context, pinging you for review as suggested 🤗

Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good! Just want to make sure we make these static since they are local to their translation unit (file).

Rogdham reacted with thumbs up emoji
Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Test failure looks unrelated. Thanks for the PR!

@AA-Turner
Copy link
Member

Note: in general we don't need to update the branch, it wastes CI resources. I tend to do so only sparingly.

@AA-TurnerAA-Turner merged commit2cc6de7 intopython:mainMay 8, 2025
38 checks passed
@AA-TurnerAA-Turner added the needs backport to 3.14bugs and security fixes labelMay 8, 2025
@miss-islington-app
Copy link

Thanks@Rogdham for the PR, and@AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 8, 2025
(cherry picked from commit2cc6de7)Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com>
@bedevere-app
Copy link

GH-133629 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 8, 2025
@emmatyping
Copy link
Member

Note: in general we don't need to update the branch, it wastes CI resources. I tend to do so only sparingly.

I only did so to sort out CI failures which would block merge.

AA-Turner reacted with thumbs up emoji

@AA-Turner
Copy link
Member

Sorry! I missed that, thanks.

@RogdhamRogdham deleted the remove-pyzstd-in-identifiers branchMay 8, 2025 05:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes

@emmatypingemmatypingemmatyping approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Rogdham@AA-Turner@emmatyping
[8]ページ先頭
©2009-2025 Movatter.jp