Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-132775: Unrevert "Add _PyCode_VerifyStateless()"#133528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commentedMay 6, 2025
edited by bedevere-appbot
Loading

This reverts commit 3c73cf5 (gh-133497), which itself reverted the original commitd270bb5 (gh-133221).

We reverted the original change due to failing android tests. The checks in_PyCode_CheckNoInternalState() were too strict, so we've relaxed them.

@ericsnowcurrently
Copy link
MemberAuthor

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@ericsnowcurrently for commitbcc081b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133528%2Fmerge

The command will test the builders whose names match following regular expression:android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

Comment on lines 637 to 638
* We consider stateless code to be "portable" if it does not return any
* any object that holds a reference to any of the code's locals. Thus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

typo: an extra "any".

ericsnowcurrently reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fixed

@ericsnowcurrentlyericsnowcurrently removed the request for review frommarkshannonMay 7, 2025 23:16
@ericsnowcurrentlyericsnowcurrentlyenabled auto-merge (squash)May 7, 2025 23:19
@ericsnowcurrentlyericsnowcurrently merged commit27128e4 intopython:mainMay 8, 2025
70 of 78 checks passed
@ericsnowcurrentlyericsnowcurrently deleted the unrevert-add-pycode-verify-stateless branchMay 8, 2025 00:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@neoneneneoneneneonene left review comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ericsnowcurrently@bedevere-bot@neonene

[8]ページ先頭

©2009-2025 Movatter.jp