Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-131798: JIT: Narrow the return type of _BINARY_SLICE to original container type#133527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…inal container typeSigned-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli, I appreciate you taking the time to do this, butsomebody else is already working on Is it okay if we close this? FYI, one issue I see here is that there is no guarantee that slicing an arbitrary object will give you the same class (we need to check for some common classes instead): >>>importmmap>>>mm=mmap.mmap(-1,42)>>> type(mm)<class'mmap.mmap'>>>>type(mm[:])<class'bytes'> |
Sorry about this! I have not noticed this has been assigned. |
Sure! |
Thanks about the explain. You prove one of my guess. |
Uh oh!
There was an error while loading.Please reload this page.
I'm not sure this patch will take some effect.
In my original thought, I think if we can setup the return type to the original container type(tuple, list etc.), the optimizer will specialize some code in the test.
but the test is not work on my thought. I guess I miss something important here. cc@brandtbucher@Fidget-Spinner