Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-133519: Add console to resources in libregrtest#133520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromaisk:test-resource-console
May 9, 2025

Conversation

aisk
Copy link
Contributor

@aiskaisk commentedMay 6, 2025
edited by bedevere-appbot
Loading

@aiskaisk added skip news needs backport to 3.13bugs and security fixes labelsMay 6, 2025
@sobolevnsobolevn requested a review fromvstinnerMay 6, 2025 20:39
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14bugs and security fixes labelMay 8, 2025
@vstinnervstinner added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 9, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@vstinner for commit16bfc9e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133520%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 9, 2025
@vstinner
Copy link
Member

I confirm that currently, many tests of test_winconsoleio are skipped because of the missingconsole resource. And it's not even possible to enableconsole resource manually, since it's rejected by libregrtest.

With this change,-u all enables all tests. Example:

test_write (test.test_winconsoleio.WindowsConsoleIOTests.test_write) ... abcabcabcabcabcabc§☃🐍§☃🐍§☃🐍§☃🐍§☃🐍§☃🐍������������������������������������������������������������§�z��☃�z���z��🐍�z���z���z��abc§abc�zabc��abc☃abc�zabc��abc�zabc��abc🐍abc�zabc��abc�zabc��abc�zabc��§☃🐍§§☃🐍�z§☃🐍��§☃🐍☃§☃🐍�z§☃🐍��§☃🐍�z§☃🐍��§☃🐍🐍§☃🐍�z§☃🐍��§☃🐍�z§☃🐍��§☃🐍�z§☃🐍������������§�����������z����������������������☃�����������z�����������������������z����������������������🐍�����������z�����������������������z�����������������������z������������ok

@vstinner
Copy link
Member

Before merging, let's see how it goes on Windows buildbots.

@vstinner
Copy link
Member

The tests passed successfully on 4 Windows buildots, that's enough for me.

@vstinnervstinner merged commit4274b47 intopython:mainMay 9, 2025
112 of 119 checks passed
@miss-islington-app
Copy link

Thanks@aisk for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 9, 2025
…3520)Add console to resources in libregrtest(cherry picked from commit4274b47)Co-authored-by: AN Long <aisk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 9, 2025
…3520)Add console to resources in libregrtest(cherry picked from commit4274b47)Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-app
Copy link

GH-133776 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 9, 2025
@bedevere-app
Copy link

GH-133777 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 9, 2025
vstinner pushed a commit that referenced this pull requestMay 9, 2025
…#133777)gh-133519: Add console to resources in libregrtest (GH-133520)Add console to resources in libregrtest(cherry picked from commit4274b47)Co-authored-by: AN Long <aisk@users.noreply.github.com>
vstinner pushed a commit that referenced this pull requestMay 9, 2025
…#133776)gh-133519: Add console to resources in libregrtest (GH-133520)Add console to resources in libregrtest(cherry picked from commit4274b47)Co-authored-by: AN Long <aisk@users.noreply.github.com>
@aiskaisk deleted the test-resource-console branchMay 10, 2025 03:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnerAwaiting requested review from vstinner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@aisk@bedevere-bot@vstinner@serhiy-storchaka

[8]ページ先頭

©2009-2025 Movatter.jp