Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133517: Remove os.listdrive, os.listvolumes and os.listmounts in non windows desktop builds#133518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 12 commits intopython:mainfrommaxbachmann:patch-1
May 7, 2025

Conversation

maxbachmann
Copy link
Contributor

@maxbachmannmaxbachmann commentedMay 6, 2025•
edited by bedevere-appbot
Loading

@maxbachmannmaxbachmann changed the titlegh-133517: GetLogicalDriveStringsW is only available on windows desktopgh-133517: Remove os.listdrive` and os.listvolumes in non windows desktop buildsMay 6, 2025
@maxbachmannmaxbachmann changed the titlegh-133517: Remove os.listdrive` and os.listvolumes in non windows desktop buildsgh-133517: Remove os.listdrive, os.listvolumes and os.listmounts in non windows desktop buildsMay 6, 2025
@maxbachmann
Copy link
ContributorAuthor

This is ready for review now

@chris-eibl
Copy link
Member

LGTM. Pinging@zooba for final steps.

…a6NgW.rstCo-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
Copy link
Member

@zoobazooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Will merge once the branch unlocks. This can be backported if needed

@maxbachmann
Copy link
ContributorAuthor

Will merge once the branch unlocks. This can be backported if needed

I don't need a backport myself. We have a patched version of Cpython anyway and just drop the patches when we upgrade to a version that includes the changes.

zooba reacted with thumbs up emoji

@zoobazooba merged commit427f8c3 intopython:mainMay 7, 2025
43 checks passed
@zooba
Copy link
Member

Well, the offer of a backport is there if someone says they need it. But if not, let's not bother.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@chris-eiblchris-eiblchris-eibl left review comments

@zoobazoobazooba approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@maxbachmann@chris-eibl@zooba@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp