Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
GH-131688: Mark instructions and uops with DECREF_INPUTS as escaping.#133501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
GH-131688: Mark instructions and uops with DECREF_INPUTS as escaping.#133501
Conversation
| @@ -832,7 +832,7 @@ def compute_properties(op: parser.CodeDef) -> Properties: | |||
| ) | |||
| error_with_pop=has_error_with_pop(op) | |||
| error_without_pop=has_error_without_pop(op) | |||
| escapes=bool(escaping_calls) | |||
| escapes=bool(escaping_calls)orvariable_used(op,"DECREF_INPUTS") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why does the cases generator not automatically detect this as an escaping call? Special casing it here seems fragile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No UPPERCASE calls are treated as escaping, since we just assume they’re macros or DSL magic. Maybe we should remove that rule and just add all of the existing stuff to the non-escaping allowlist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
DECREF_INPUTS is not treated as an escaping call. We treat it specially.
So we'd need to add it to the whitelist and still add this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good. Not a huge fan of special-cases, but they can be hard to avoid in situations like this.
fbe7b87 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
DECREF_INPUTS()should be escaping #131688