Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132775: Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)"#133497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 1 commit intopython:mainfromencukou:revert-d270bb5
May 6, 2025

Conversation

encukou
Copy link
Member

@encukouencukou commentedMay 6, 2025•
edited by bedevere-appbot
Loading

This reverts commitd270bb5.

Note that the test functions in _code_definitions are not reverted.

…)"This reverts commitd270bb5.Note that the test functions in _code_definitions are not reverted.
@encukouencukou changed the titleRevert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)"gh-132775: Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)"May 6, 2025
@encukou
Copy link
MemberAuthor

@hugovk I need to step away for a doctor's appointment. Here's what I have, I haven't checked this very well.

@hugovk
Copy link
Member

@encukou Thank you!

@hugovk
Copy link
Member

!buildbot ios

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@hugovk for commite7d7e26 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133497%2Fmerge

The command will test the builders whose names match following regular expression:ios

The builders matched are:

  • iOS ARM64 Simulator PR

@hugovk
Copy link
Member

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@hugovk for commite7d7e26 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133497%2Fmerge

The command will test the builders whose names match following regular expression:android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

@ambv
Copy link
Contributor

ambv commentedMay 6, 2025

iOS buildbot green! No Android results yet.

@ambv
Copy link
Contributor

ambv commentedMay 6, 2025

It's weird since the Android builders aren't building anything else at the moment. Looking at buildmaster.

@ambv
Copy link
Contributor

ambv commentedMay 6, 2025

Master claims it added jobs:

2025-05-06 07:36:07+0000 [HTTP11ClientProtocol (BufferingTLSTransport),client] Received 1 changes from GitHub PR #1334972025-05-06 07:36:07+0000 [-] added change with revision e7d7e26eee5fa9dcd6b23d1dd00f96cd083aff8b to database2025-05-06 07:36:07+0000 [-] injected change 41998

Weird. Let's try again.

@ambv
Copy link
Contributor

ambv commentedMay 6, 2025

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@ambv for commite7d7e26 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133497%2Fmerge

The command will test the builders whose names match following regular expression:android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

@ambv
Copy link
Contributor

ambv commentedMay 6, 2025

Now it worked, builds started.

hugovk reacted with thumbs up emoji

@hugovk
Copy link
Member

And Android green.

@hugovkhugovk merged commit3c73cf5 intopython:mainMay 6, 2025
45 checks passed
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull requestMay 6, 2025
ericsnowcurrently added a commit that referenced this pull requestMay 8, 2025
This reverts commit 3c73cf5 (gh-133497), which itself revertedthe original commitd270bb5 (gh-133221).We reverted the original change due to failing android tests.The checks in _PyCode_CheckNoInternalState() were too strict,so we've relaxed them.
ericsnowcurrently added a commit that referenced this pull requestMay 8, 2025
This reverts commit 3c73cf5 (gh-133497), which itself revertedthe original commitd270bb5 (gh-133221).We reverted the original change due to failing android tests.The checks in _PyCode_CheckNoInternalState() were too strict,so we've relaxed them.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@encukou@hugovk@bedevere-bot@ambv
[8]ページ先頭
©2009-2025 Movatter.jp