Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-132775: Expand the Capability of Interpreter.call()#133484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ericsnowcurrently wants to merge4 commits intopython:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
gh-132775: Expand the Capability of Interpreter.call()#133484
ericsnowcurrently wants to merge4 commits intopython:mainfromericsnowcurrently:interp-call-expansion
+982 −231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4fdc11a to4327098Compare27d83f1 tof9f7666Comparef9f7666 tob8171d9Compare Comment on lines +235 to 238
| def call(self, callable, /, *args, **kwargs): | ||
| """Call the object in the interpreter with given args/kwargs. | ||
| Only functions that take no arguments and have no closure |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The docstring looks partially outdated (here or inLib/interpreters/__init__.py). The same would apply for_interpretersmodule.c?
PyDoc_STRVAR(exec_doc,...- The code/function must not take any arguments or be a closure (i.e. have cell vars).+ The code/function must not take any arguments.PyDoc_STRVAR(run_func_doc,...- In both cases, closures and args are not supported.
d58f54e to4152f17Compare4152f17 tod173ec0CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
It now supports most callables, full args, and return values.