Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
GH-132983: Use a standard autoconf version check for zstd#133479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bedevere-bot commentedMay 5, 2025
🤖 New build scheduled with the buildbot fleet by@AA-Turner for commitafbc562 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133479%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
@AA-Turner That looks promising: it seems to handle my use case. Thanks! cc:@emmatyping |
... and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! I didn't know this was something one could do. TIL
I'd like to wait for a RHEL8 buildbot to go green before merging to ensure that it works when there is a version of libzstd that is too old. Otherwise it looks much better.
And thank you for catching the original issue@ned-deily ! |
There is always something in Autotools that no one knows you can do. |
https://buildbot.python.org/#/builders/170/builds/1765 Seems to work. A |
793402e intopython:mainUh oh!
There was an error while loading.Please reload this page.
pythonGH-133479 removed the logic to check for libzstd outside of pkg-config.This commit adds that logic back with a check for the version so thatusers can provide their own libzstd. This is to bring parity with lzma,bz2, and zlib detection.
pythonGH-133479 removed the logic to check for libzstd outside of pkg-config.This commit adds that logic back with a check for the version so thatusers can provide their own libzstd. This is to bring parity with lzma,bz2, and zlib detection.
Uh oh!
There was an error while loading.Please reload this page.
cc@ned-deily, it seems that this works & is simpler? I'll run buildbots.
A