Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-132983: Use a standard autoconf version check for zstd#133479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 1 commit intopython:mainfromAA-Turner:zstd-conf
May 6, 2025

Conversation

@AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commentedMay 5, 2025•
edited by bedevere-appbot
Loading

cc@ned-deily, it seems that this works & is simpler? I'll run buildbots.

A

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@AA-Turner for commitafbc562 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133479%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 5, 2025
@ned-deily
Copy link
Member

@AA-Turner That looks promising: it seems to handle my use case. Thanks!

cc:@emmatyping

@ned-deily
Copy link
Member

... and theghcr.io/cirruslabs/macos-runner:sonoma runner also now appears to successfully build_zstd.

emmatyping reacted with hooray emoji

Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! I didn't know this was something one could do. TIL

I'd like to wait for a RHEL8 buildbot to go green before merging to ensure that it works when there is a version of libzstd that is too old. Otherwise it looks much better.

@emmatyping
Copy link
Member

And thank you for catching the original issue@ned-deily !

ned-deily reacted with thumbs up emoji

@ned-deily
Copy link
Member

I didn't know this was something one could do.

There is always something in Autotools that no one knows you can do.

erlend-aasland reacted with thumbs up emojiemmatyping reacted with laugh emoji

@AA-Turner
Copy link
MemberAuthor

https://buildbot.python.org/#/builders/170/builds/1765

checking for libzstd >= 1.4.5... nochecking for zstd.h... nochecking for zdict.h... no...checking for stdlib extension module _zstd... missing

Seems to work.

A

emmatyping reacted with thumbs up emoji

@AA-TurnerAA-Turner requested a review fromemmatypingMay 6, 2025 00:29
@AA-TurnerAA-Turner merged commit793402e intopython:mainMay 6, 2025
56 of 63 checks passed
@AA-TurnerAA-Turner deleted the zstd-conf branchMay 6, 2025 00:35
emmatyping added a commit to emmatyping/cpython that referenced this pull requestMay 7, 2025
pythonGH-133479 removed the logic to check for libzstd outside of pkg-config.This commit adds that logic back with a check for the version so thatusers can provide their own libzstd. This is to bring parity with lzma,bz2, and zlib detection.
emmatyping added a commit to emmatyping/cpython that referenced this pull requestMay 12, 2025
pythonGH-133479 removed the logic to check for libzstd outside of pkg-config.This commit adds that logic back with a check for the version so thatusers can provide their own libzstd. This is to bring parity with lzma,bz2, and zlib detection.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull requestJul 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AA-Turner@bedevere-bot@ned-deily@emmatyping
[8]ページ先頭
©2009-2025 Movatter.jp