Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-133447: Add basic color tosqlite3 CLI#133461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 16 commits intopython:mainfromStanFromIreland:color_step1
May 10, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIrelandStanFromIreland commentedMay 5, 2025
edited
Loading

edgarrmondragon reacted with heart emojiambv reacted with rocket emoji
Copy link
Contributor

@sharktidesharktide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems good to me

@tomasr8
Copy link
Member

Now that#133347 has been merged, we could take advantage of it in the sqlite CLI as well?

StanFromIreland reacted with thumbs up emoji

@StanFromIreland
Copy link
ContributorAuthor

cc@ambv Just to check -- did I use themes correctly or did I do something wrong (there is no docs at the moment to verify)?

Copy link
Contributor

@ambvambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, there are no docs so I'll push here with how I'd do it if that's okay.

StanFromIreland reacted with heart emoji
@StanFromIrelandStanFromIreland requested a review fromambvMay 6, 2025 18:27
Copy link
Contributor

@ambvambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let me know what you think.

@StanFromIreland
Copy link
ContributorAuthor

Looks good to me now, thank you for the assistance:-)

If you need help with colorise I’d be happy to lend a hand.

ambv reacted with thumbs up emoji

@ambv
Copy link
Contributor

ambv commentedMay 6, 2025

Excellent! Since all this is already for 3.15, I think we might attempt a SQL syntax highlighter as well, although I'm not entirely sure our tokenizer will take kindly to it, so this might become a larger task. We have plenty of time, though.

StanFromIreland and erlend-aasland reacted with thumbs up emoji

@erlend-aaslanderlend-aasland changed the titlegh-133447: Add basic color tosqlite3 cligh-133447: Add basic color tosqlite3 CLIMay 7, 2025
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland
Copy link
Contributor

Excellent! Since all this is already for 3.15, I think we might attempt a SQL syntax highlighter as well, although I'm not entirely sure our tokenizer will take kindly to it, so this might become a larger task. We have plenty of time, though.

SQL highlighting would be awesome.

@StanFromIreland
Copy link
ContributorAuthor

StanFromIreland commentedMay 7, 2025
edited
Loading

All the test fails are unrelated.

SQL highlighting would be awesome.

Working on it :-)

erlend-aasland reacted with rocket emoji

@erlend-aasland
Copy link
Contributor

@StanFromIreland, please look into the failing tests.

@StanFromIreland
Copy link
ContributorAuthor

I was testing the broken behavior that was now fixed, oops!

@StanFromIreland
Copy link
ContributorAuthor

@erlend-aasland Test has been corrected to work with the new updates.

erlend-aasland reacted with thumbs up emoji

@erlend-aaslanderlend-aaslandenabled auto-merge (squash)May 10, 2025 07:35
@erlend-aaslanderlend-aasland merged commit30b1d8f intopython:mainMay 10, 2025
39 checks passed
@StanFromIrelandStanFromIreland deleted the color_step1 branchMay 10, 2025 07:59
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM64 Windows 3.x (tier-3) has failed when building commit30b1d8f.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/729/builds/8781) and take a look at the build logs.
  4. Check if the failure is related to this commit (30b1d8f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/729/builds/8781

Failed tests:

  • test_zipfile

Failed subtests:

  • test_write_without_source_date_epoch - test.test_zipfile.test_core.OtherTests.test_write_without_source_date_epoch

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\test_zipfile\test_core.py", line1832, intest_write_without_source_date_epochself.assertAlmostEqual(z_time, c_time,delta=1)~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:28 != 30 within 1 delta (2 difference)Traceback (most recent call last):  File"C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\test_zipfile\test_core.py", line1832, intest_write_without_source_date_epochself.assertAlmostEqual(z_time, c_time,delta=1)~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:36 != 38 within 1 delta (2 difference)

@StanFromIreland
Copy link
ContributorAuthor

Unrelated.

tanloong pushed a commit to tanloong/cpython that referenced this pull requestMay 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk left review comments

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@ambvambvambv approved these changes

@sharktidesharktidesharktide approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@StanFromIreland@tomasr8@ambv@erlend-aasland@bedevere-bot@hugovk@sharktide

[8]ページ先頭

©2009-2025 Movatter.jp