Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-133448: Fix test_file in test_urllib2 on Windows with a longer repo path#133449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
@aisk NB: The review would go a lot faster if you were to add a short PR description of your changes |
@sharktide Thanks for noticing, updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I know this is kinda a stupid question, but have you tested this new version of your test script on a windows long path? (I know people who wouldn't not saying its you just trying to expedite the core review process then) :)
*GitHub Actions won't fail because it is a short path.
Uh oh!
There was an error while loading.Please reload this page.
Before this PR, the
urlwould become something likefile://somerandomhost.ontheinternet.comC:\Users\xxxxx\Source\cpython\build\test_python_worker_4676æ/@test_4676_tmpæon Windows, which would fail (more details in the linked issue).In this PR, the
urlbecomesfile://somerandomhost.ontheinternet.com/Users/xxxxx/Source/cpython/build/test_python_worker_4676æ/@test_4676_tmpæ, which is valid and expected.test_filefailed on Windows with a longer repo path intest_urllib2#133448