NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

[GH-133419] fix test_external_inspection race assert#133422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gpshead merged 1 commit intopython:mainfromgpshead:gps/fix_test_external_inspection_race_maybe

May 5, 2025

Merged

[GH-133419] fix test_external_inspection race assert#133422

gpshead merged 1 commit intopython:mainfromgpshead:gps/fix_test_external_inspection_race_maybe

May 5, 2025

Conversation

Copy link

Member

gpshead commentedMay 5, 2025•
edited
Loading

either line could be where the inspection finds the foo() function as after ready is sent, the process may not have made progress onto the next line yet. "solve" by putting the statements on the same line. simpler than asserting for multiple possible line values.

Fixes#133419.
Closes#133419.

Issue:test_external_inspection fails on Ubuntu #133419

[tests] fix test_external_inspection race assert

b3a42cc

either line could be where the inspection finds the foo()function as after ready is sent, the process may not have made progressonto the next line yet.  "solve" by putting the statements on the sameline.

gpshead added the testsTests in the Lib/test dir label

May 5, 2025

gpshead requested a review frompablogsal

May 5, 2025 04:16