Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-133410: Use commit hashes for change detection#133416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 2 commits intopython:mainfromAA-Turner:changes-diff-sha
May 5, 2025

Conversation

AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commentedMay 5, 2025•
edited by bedevere-appbot
Loading

As seen recently, if the pull-request branch on a fork repository has the same name as the target branch on the upstream repository, the branches shadow each other when set up by@actions/checkout, meaning that change detection passes with no changes having occured.

This changes to instead perform thegit diff with the commit SHA of the head commit. This is slightly tricky due to what GitHub exposes, but in short, we always compare the tip of the PR branch (fork) against the default branch (upstream).

A

cc@JelleZijlstra

@AA-TurnerAA-Turner added skip news infraCI, GitHub Actions, buildbots, Dependabot, etc. labelsMay 5, 2025
@AA-TurnerAA-Turner requested a review from1st1 as acode ownerMay 5, 2025 00:22
@ambvambv merged commitd530e74 intopython:mainMay 5, 2025
42 checks passed
@hugovkhugovk added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsMay 5, 2025
@miss-islington-app
Copy link

Thanks@AA-Turner for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@AA-Turner for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 5, 2025
)(cherry picked from commitd530e74)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 5, 2025
)(cherry picked from commitd530e74)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

GH-133426 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelMay 5, 2025
@bedevere-app
Copy link

GH-133427 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 5, 2025
@hugovk
Copy link
Member

Also needs backporting to 3.12 so the CI isn't skipped there.

@hugovk
Copy link
Member

hugovk commentedMay 5, 2025•
edited
Loading

And let's updateCODEOWNERS so@1st1 isn't mistakenly pinged for reviews on.github/workflows/reusable-context.yml due to:

# Core
**/*context*@1st1

JelleZijlstra pushed a commit that referenced this pull requestMay 5, 2025
…133427)GH-133410: Use commit hashes for change detection (gh-133416)(cherry picked from commitd530e74)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull requestMay 5, 2025
…133426)GH-133410: Use commit hashes for change detection (gh-133416)(cherry picked from commitd530e74)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@emmatyping
Copy link
Member

I believe this broke change detection in personal/forked branches prefixed with e.g.3.14-. For examplehttps://github.com/emmatyping/cpython/actions/runs/14848418162/job/41687428491

@hugovk
Copy link
Member

Oh yes, let's fix that :)

@hugovk
Copy link
Member

hugovk added a commit to hugovk/cpython that referenced this pull requestMay 8, 2025
@hugovk
Copy link
Member

Let's continue in the issue,#133410.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

Assignees
No one assigned
Labels
infraCI, GitHub Actions, buildbots, Dependabot, etc.skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@AA-Turner@hugovk@emmatyping@JelleZijlstra@ambv
[8]ページ先頭
©2009-2025 Movatter.jp