Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133413: Change the request.Request example method#133414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ppaez
Copy link
Contributor

@ppaezppaez commentedMay 5, 2025•
edited by github-actionsbot
Loading

The method has_data of request.Request is used in the explanation of mock autospeccing. This method was removed in version 3.4. This PR proposes to use header_items instead.

📚 Documentation preview 📚:https://cpython-previews--133414.org.readthedocs.build/

has_data is used in the explanation of mock autospeccing. Thismethod of request.Request was removed in version 3.4.
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@serhiy-storchaka
Copy link
Member

Thehas_data() method is also referred in the documentation forHTTPHandler.http_open() andHTTPSHandler.https_open(). Do you mind to fix also these descriptions?

@ppaez
Copy link
ContributorAuthor

Thanks of reviewing this issue. I can propose a fix for the two other references tohas_data. At first glance, it seems that thedata attribute could be used instead, not sure if the wordingdepending on req.data. needs to change. I would like to investigate further and do some testing to confirm. Would it be ok to wait on this or do you prefer me to fix those two references in a separate Issue?

@serhiy-storchaka
Copy link
Member

I would prefer to fix them all in one PR.

This is just a documentation issue, and it is old, so few days or weeks don't matter.

ppaez reacted with thumbs up emoji

has_data was removed in version 3.4
@ppaez
Copy link
ContributorAuthor

Hi@serhiy-storchaka, I added a commit to fix the two references.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@serhiy-storchakaserhiy-storchaka added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 12, 2025
@serhiy-storchakaserhiy-storchaka merged commit86c1d43 intopython:mainMay 12, 2025
28 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMay 12, 2025
@miss-islington-app
Copy link

Thanks@ppaez for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 12, 2025
…-133414)The has_data() method of http.request.Requestwas removed in version 3.4.(cherry picked from commit86c1d43)Co-authored-by: ppaez <pp@pp.com.mx>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 12, 2025
…-133414)The has_data() method of http.request.Requestwas removed in version 3.4.(cherry picked from commit86c1d43)Co-authored-by: ppaez <pp@pp.com.mx>
@bedevere-app
Copy link

GH-133945 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 12, 2025
@bedevere-app
Copy link

GH-133946 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 12, 2025
@serhiy-storchaka
Copy link
Member

Thank you for your contribution@ppaez.

serhiy-storchaka pushed a commit that referenced this pull requestMay 12, 2025
…) (GH-133945)The has_data() method of http.request.Requestwas removed in version 3.4.(cherry picked from commit86c1d43)Co-authored-by: ppaez <pp@pp.com.mx>
serhiy-storchaka pushed a commit that referenced this pull requestMay 12, 2025
…) (GH-133946)The has_data() method of http.request.Requestwas removed in version 3.4.(cherry picked from commit86c1d43)Co-authored-by: ppaez <pp@pp.com.mx>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ppaez@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp