Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
GH-91048: Minor fixes for_remotedebugging & rename to_remote_debugging#133398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks a lot for the fix@AA-Turner! |
Yep, if you want, go ahead and make the changes |
configure.ac Outdated
| @@ -8077,6 +8077,7 @@ PY_STDLIB_MOD([_gdbm], | |||
| PY_STDLIB_MOD([readline], | |||
| [], [test "$with_readline" != "no"], | |||
| [$READLINE_CFLAGS], [$READLINE_LIBS]) | |||
| PY_STDLIB_MOD([_remotedebugging], [test "$TEST_MODULES" = yes]) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@pablogsal should we keep this"$TEST_MODULES" = yes condition? It's inherited from before the rename, but I don't know what conditions you want the module to be enabled under.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nop, that was from before when this was a test module. Let's remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, I've pushed a fix for this & also the rename to_remote_debugging. Thanks!
_remotedebugging & rename to_remote_debuggingbedevere-bot commentedMay 4, 2025
🤖 New build scheduled with the buildbot fleet by@AA-Turner for commit2e6b80e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133398%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
# Conflicts:#PCbuild/pcbuild.sln
Hummmm, seems that this collided with the other PR, could you rebase? I can land it afterwards. If you don't have time I can rebase myself if you prefer :) |
# Conflicts:#Lib/test/test_external_inspection.py
Thanks! resolved conflicts A |
3f80165 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks again 🖤 |
Uh oh!
There was an error while loading.Please reload this page.
cc@pablogsal, a few minor things I spotted after the rename in#133284.
Btw, would you support adding an underscore to the module name? I keep reading it as 'remoted ...', and
_remote_debuggingwould better match the C files.A