Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.3k
gh-133395: add option for extension modules to specialize BINARY_OP/SUBSCR, apply to arrays#133396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
22 commits Select commitHold shift + click to select a range
79e45a1
plumbing for registering specialization
iritkatriel72dfba4
basic array plugin
iritkatriel70ebe71
use PyType_GetBaseByToken
iritkatrield42d2a6
method on type
iritkatriel8fda407
fix error
iritkatriel726fa81
📜🤖 Added by blurb_it.
blurb-it[bot]b47c149
typo
iritkatriel0abb509
const
iritkatriel2b4c610
const
iritkatriel89b6c37
set oparg, check *descr
iritkatriel6630a95
add free
iritkatrielf42d42f
review comments
iritkatriel509b27f
whitespace
iritkatriel5c1ed68
fix error
iritkatrielfd24d7b
remove unused
iritkatrielb15ad61
use Py_ARRAY_LENGTH
iritkatriel81a3008
fix deopt
iritkatriel0190ecf
'experimental' comment
iritkatrield8b5848
Merge branch 'main' into array_subscr
iritkatriel78f0576
credits
iritkatriel90fb993
comment on commutativity
iritkatriel454bfc5
Apply suggestions from code review
iritkatrielFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
const
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit2b4c610f72eda12c4e65894022272dc3e2db5b33
There are no files selected for viewing
2 changes: 1 addition & 1 deletionPython/specialize.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -2563,7 +2563,7 @@ binary_op_extended_specialization(PyObject *lhs, PyObject *rhs, int oparg, | ||
typedef _PyBinaryOpSpecializationDescr descr_type; | ||
size_t size = sizeof(binaryop_extend_builtins)/sizeof(descr_type); | ||
iritkatriel marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
for (size_t i = 0; i < size; i++) { | ||
descr_type *d =(descr_type *)&binaryop_extend_builtins[i]; | ||
assert(d != NULL); | ||
assert(d->guard != NULL); | ||
if (d->oparg == oparg && d->guard(lhs, rhs)) { | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.