Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-133390: Support basic completion for sqlite3 command-line interface#133393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
tanloong wants to merge37 commits intopython:main
base:main
Choose a base branch
Loading
fromtanloong:sqlite3-cli-completion
Open
Changes from1 commit
Commits
Show all changes
37 commits
Select commitHold shift + click to select a range
1b96be3
Support basic completion for sqlite3 command-line interface
tanloongMay 4, 2025
5e50871
Add news entry
tanloongMay 4, 2025
c1941cb
Move completion code to separate module
tanloongMay 4, 2025
47daca5
Update Lib/sqlite3/_completer.py
tanloongMay 4, 2025
c54c2f6
Update Doc/whatsnew/3.14.rst
tanloongMay 4, 2025
8fff491
Add test
tanloongMay 5, 2025
a766805
Move keyword list to module level
tanloongMay 5, 2025
da55014
Remove whatsnew entry from 3.14
tanloongMay 5, 2025
ca587e0
Avoid regeneration of candidates. Store them when state is 0 and returns
tanloongMay 7, 2025
311b4f3
Add whatsnew entry to 3.15
tanloongMay 7, 2025
70f46e9
Address Bénédikt's review
tanloongMay 10, 2025
9d03730
Remove color handling of output; If CI fails might need to add back
tanloongMay 10, 2025
bfcff38
Fix `run_pty()` doesn't return and test hangs
tanloongMay 10, 2025
805d997
Revert "Remove color handling of output; If CI fails might need to ad…
tanloongMay 10, 2025
276b4a7
Turn off colored-completion-prefix for readline
tanloongMay 10, 2025
09eeac8
No need to pass "NO_COLOR" to `run_pty()`
tanloongMay 10, 2025
fc57d71
Flip name
tanloongMay 10, 2025
c508069
Triggering completion on Ubuntu requires 2 tabs
tanloongMay 10, 2025
231b9e7
Move KEYWORDS to C
tanloongMay 10, 2025
121b069
Improve style of C code
tanloongMay 10, 2025
90a86cf
Improve tests
tanloongMay 11, 2025
5170733
Address Bénédikt's review
tanloongMay 16, 2025
b40982a
Revert "Improve style of C code"
tanloongMay 16, 2025
226ea9f
Revert "Move KEYWORDS to C"
tanloongMay 16, 2025
4eebbd9
Read keyword names dynamically
encukouMay 16, 2025
3f9b2c1
Check candidates against KEYWORDS
tanloongMay 16, 2025
0410fa2
Use slice to get candidates
tanloongMay 16, 2025
bd0b9ce
Address Bénédikt's review
tanloongMay 16, 2025
35a17e7
Make candidates tuple
tanloongMay 16, 2025
3dd16b3
Revert "Revert "Move KEYWORDS to C""
tanloongMay 16, 2025
f3ea951
Revert "Revert "Improve style of C code""
tanloongMay 16, 2025
a493ad3
Merge pull request #2 from encukou/sqlite3-cli-completion
tanloongMay 16, 2025
34cfc78
Fix 'KEYWORDS' not found
tanloongMay 16, 2025
477b48b
Sort keywords before checking the equality
tanloongMay 16, 2025
68bb4f3
Fix comparing between tuple and list
tanloongMay 16, 2025
4c3b122
Fix comparing between tuple and list
tanloongMay 16, 2025
4f1221e
Rename 'test_completion_order' to 'test_completion_for_nothing'
tanloongMay 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Sort keywords before checking the equality
GNU Readline always sorts completions before displaying them. There is a [rl_sort_completion_matches](https://git.savannah.gnu.org/cgit/readline.git/tree/complete.c#n411) in Readline's source code but it's not exposed as a config flag.
  • Loading branch information
@tanloong
tanloong committedMay 16, 2025
commit477b48b2ec15d2596f53a6ed6ec09a581e7a6b15
2 changes: 1 addition & 1 deletionLib/test/test_sqlite3/test_cli.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -273,7 +273,7 @@ def test_completion_order(self):
self.assertEqual(len(indices), 2)
start, end = indices[0] + 1, indices[1]
candidates = tuple(map(str.strip, output_lines[start:end]))
self.assertEqual(candidates, SQLITE_KEYWORDS)
self.assertEqual(candidates,sorted(SQLITE_KEYWORDS))


if __name__ == "__main__":
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp