Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-133390: Support basic completion for sqlite3 command-line interface#133393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
tanloong wants to merge37 commits intopython:mainChoose a base branch fromtanloong:sqlite3-cli-completion
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+169 −6
Open
Changes from1 commit
Commits
Show all changes
37 commits Select commitHold shift + click to select a range
1b96be3
Support basic completion for sqlite3 command-line interface
tanloong5e50871
Add news entry
tanloongc1941cb
Move completion code to separate module
tanloong47daca5
Update Lib/sqlite3/_completer.py
tanloongc54c2f6
Update Doc/whatsnew/3.14.rst
tanloong8fff491
Add test
tanloonga766805
Move keyword list to module level
tanloongda55014
Remove whatsnew entry from 3.14
tanloongca587e0
Avoid regeneration of candidates. Store them when state is 0 and returns
tanloong311b4f3
Add whatsnew entry to 3.15
tanloong70f46e9
Address Bénédikt's review
tanloong9d03730
Remove color handling of output; If CI fails might need to add back
tanloongbfcff38
Fix `run_pty()` doesn't return and test hangs
tanloong805d997
Revert "Remove color handling of output; If CI fails might need to ad…
tanloong276b4a7
Turn off colored-completion-prefix for readline
tanloong09eeac8
No need to pass "NO_COLOR" to `run_pty()`
tanloongfc57d71
Flip name
tanloongc508069
Triggering completion on Ubuntu requires 2 tabs
tanloong231b9e7
Move KEYWORDS to C
tanloong121b069
Improve style of C code
tanloong90a86cf
Improve tests
tanloong5170733
Address Bénédikt's review
tanloongb40982a
Revert "Improve style of C code"
tanloong226ea9f
Revert "Move KEYWORDS to C"
tanloong4eebbd9
Read keyword names dynamically
encukou3f9b2c1
Check candidates against KEYWORDS
tanloong0410fa2
Use slice to get candidates
tanloongbd0b9ce
Address Bénédikt's review
tanloong35a17e7
Make candidates tuple
tanloong3dd16b3
Revert "Revert "Move KEYWORDS to C""
tanloongf3ea951
Revert "Revert "Improve style of C code""
tanloonga493ad3
Merge pull request #2 from encukou/sqlite3-cli-completion
tanloong34cfc78
Fix 'KEYWORDS' not found
tanloong477b48b
Sort keywords before checking the equality
tanloong68bb4f3
Fix comparing between tuple and list
tanloong4c3b122
Fix comparing between tuple and list
tanloong4f1221e
Rename 'test_completion_order' to 'test_completion_for_nothing'
tanloongFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Sort keywords before checking the equality
GNU Readline always sorts completions before displaying them. There is a [rl_sort_completion_matches](https://git.savannah.gnu.org/cgit/readline.git/tree/complete.c#n411) in Readline's source code but it's not exposed as a config flag.
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit477b48b2ec15d2596f53a6ed6ec09a581e7a6b15
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.