All commit authors signed the Contributor License Agreement.

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

I think we need a separate nodule for this because if we want to have a smarter completion later the code is better to be isolated, so something like sqlite3._completer.

If possible, can we have anautogenerated list of keywords? and those keywords could also be stored in a (private) module-level list.

Please add tests

Yes, tests is coming. I will try to find a way to autogenerate list of keywords.

You can mark the pr as a draft.

Added tests and moved keyword list to module level.

Keywords seems not easy to auto-generate, theSQLite document says they can be accessed bysqlite3_keyword_count() andsqlite3_keyword_name() using C, but I am bad at C and didn't figure out how to call these two at Python level. I think these two functions are not exposed to Python?

Hi@picnixz, as Stan mentioned, beta freeze is around the corner, but I really hope this can be shipped in 3.14, do you think there is a chance to merge it before beta freeze?

The SQLITE_KEYWORDS is moved from C back to Python.

If you want it in C, you need to combineint sqlite3_keyword_count(void) andint sqlite3_keyword_name(int,const char**,int*);. Stated otherwise, you need to first count the number of keywords, then loop over this number and get the n-th keyword usingsqlite3_keyword_name. But for now, let's simply keep them in Python. We'll do it in a follow-up PR (or I'll do it as the task is a bit harder)

On my side it looks great but I'll also want@erlend-aasland to have a look as he's the main maintainer. Maybe he'l ask for some stylistic changes (in which case I'm sorry if I suggested something wrong).

Thank you so much for your review. Really appreciate your guidance!

Thetest_completion_order() fails. TheSQLITE_KEYWORDS given bysqlite3_keyword_name() andsqlite3_keyword_count() is not in alphabetical order, but GNU Readline always sorts completions before displaying them.

Unfortunately I didn't find adisable-completion-sorting-like option in GNU Readline's document. There is anrl_sort_completion_matches in Readline's source code but it's not exposed as a config flag.

Can we remove thistest_completion_order(), as the order of displayed candidates is controlled by GNU Readline.

Let's just check that the completion of nothing returns all keywords. You can sort theSQLITE_KEYWORDS list before checking for the equality (I think it's better not to sort it at the C level as it could be helpful in the future for someone interacting with python and C)