Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-91048: Add filename and line number to external inspection routines#133385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 1 commit intopython:mainfrompablogsal:other
May 4, 2025

Conversation

pablogsal
Copy link
Member

@pablogsalpablogsal commentedMay 4, 2025•
edited by bedevere-appbot
Loading

Copy link
Member

@1st11st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Merry x-mas! This is very cool. Left a couple of nit comments, looks great otherwise! <3

@pablogsalpablogsalforce-pushed theother branch 4 times, most recently frome16d029 to1312fb5CompareMay 4, 2025 17:30
@@ -27,6 +27,7 @@ def _index(result):
for tid, tname, awaited in tasks:
id2name[tid] = tname
for stack, parent_id in awaited:
stack = [elem[0] if isinstance(elem, tuple) else elem for elem in stack]
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@ambv This code just returns the fully qualified name. Play a bit with this and decide how we want to format this in the tool

ambv reacted with thumbs up emoji
@pablogsal
Copy link
MemberAuthor

No ref leaks:

.venv ❯ sudo -E ./python.exe -m test test_external_inspection -R :Using random seed: 1218919259Raised RLIMIT_NOFILE: 256 -> 10240:00:00 load avg: 9.64 Run 1 test sequentially in a single process0:00:00 load avg: 9.64 [1/1] test_external_inspectionbeginning 9 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more)12345:6789XX... ....0:00:47 load avg: 6.37 [1/1] test_external_inspection passed in 47.2 sec== Tests result: SUCCESS ==1 test OK.Total duration: 47.2 secTotal tests: run=7Total test files: run=1/1Result: SUCCESS
ambv and chris-eibl reacted with thumbs up emoji

@pablogsalpablogsal added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 4, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@pablogsal for commiteabbf17 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133385%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 4, 2025
…outinesSigned-off-by: Pablo Galindo <pablogsal@gmail.com>
@ambvambv merged commit3109c47 intopython:mainMay 4, 2025
41 checks passed
diegorusso added a commit to diegorusso/cpython that referenced this pull requestMay 4, 2025
* origin/main: (111 commits)pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385)pythongh-131178: Add tests for `ast` command-line interface (python#133329)  Regenerate pcbuild.sln in Visual Studio 2022 (python#133394)pythongh-133042: disable HACL* HMAC on Emscripten (python#133064)pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387)pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946)pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388)pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830)pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368)pythongh-132457: make staticmethod and classmethod generic (python#132460)pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812)pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490)pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517)pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628)pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358)  bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226)pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287)pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364)pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027)pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@1st11st11st1 left review comments

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@pablogsal@bedevere-bot@1st1@ambv
[8]ページ先頭
©2009-2025 Movatter.jp