Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133379: Correct usage ofarguments in error messages#133382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 5 commits intopython:mainfromStanFromIreland:correct-errors
May 10, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIrelandStanFromIreland commentedMay 4, 2025•
edited by bedevere-appbot
Loading

Not quite sure what the title should be for this.

Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Title looks great to me

StanFromIreland reacted with heart emoji
@picnixz
Copy link
Member

The title could be about correcting the places where theterm argument is incorrectly used, but your title is fine.

StanFromIreland reacted with thumbs up emoji

@serhiy-storchaka
Copy link
Member

What is the difference between#133382 and#133463?

@StanFromIreland
Copy link
ContributorAuthor

Other error messages are corrected.

@picnixz
Copy link
Member

Following#133463 (comment), I suggest we fix everything here.

StanFromIreland reacted with thumbs up emoji

@StanFromIreland
Copy link
ContributorAuthor

All complete, I included@serhiy-storchaka extra example and two more I found. Added an entry to whatsnew since this affects quite a few error messages.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

StanFromIreland reacted with heart emoji
@serhiy-storchakaserhiy-storchaka merged commitdbca27c intopython:mainMay 10, 2025
39 checks passed
@StanFromIrelandStanFromIreland deleted the correct-errors branchMay 10, 2025 12:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@picnixzpicnixzpicnixz approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@ambvambvAwaiting requested review from ambvambv is a code owner

@carljmcarljmAwaiting requested review from carljmcarljm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@StanFromIreland@picnixz@serhiy-storchaka@JelleZijlstra
[8]ページ先頭
©2009-2025 Movatter.jp