NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

[3.13] gh-122559: Synchronize C and Python implementation of the io module about pickling (GH-122628)#133381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 1 commit intopython:3.13fromserhiy-storchaka:backport-e9253eb-3.13

May 4, 2025

Merged

[3.13] gh-122559: Synchronize C and Python implementation of the io module about pickling (GH-122628)#133381

serhiy-storchaka merged 1 commit intopython:3.13fromserhiy-storchaka:backport-e9253eb-3.13

May 4, 2025

Conversation

Copy link

Member

serhiy-storchaka commentedMay 4, 2025•
edited by bedevere-appbot
Loading

In the C implementation, removereduce andreduce_ex methods that always raise TypeError and restoregetstate methods that always raise TypeErrori.

This restores fine details of the pre-3.12 behavior and unifies both implementations.
(cherry picked from commite9253eb)

Issue:Pickle ignores custom getstate methods on TextIOWrapper in Python 3.12 #122559

[3.13]pythongh-122559: Synchronize C and Python implementation of th…

4f0dbd0

…e io module about pickling (pythonGH-122628)In the C implementation, remove __reduce__ and __reduce_ex__ methodsthat always raise TypeError and restore __getstate__ methods that alwaysraise TypeErrori.This restores fine details of the pre-3.12 behavior and unifiesboth implementations.(cherry picked from commite9253eb)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>