Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133367: Add missing options toast CLI#133369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 13 commits intopython:mainfromdonBarbos:issue-133367
May 5, 2025

Conversation

donBarbos
Copy link
Contributor

@donBarbosdonBarbos commentedMay 4, 2025•
edited by github-actionsbot
Loading

I wasn't sure about adding whatsnew entry but I added it so we can remote it

*Headings were corrected according to thedevguide

cc@sobolevn

📚 Documentation preview 📚:https://cpython-previews--133369.org.readthedocs.build/

@skirpichevskirpichev requested a review fromsobolevnMay 4, 2025 10:37
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please, don't forget to add tests in your other PR

@skirpichev
Copy link
Contributor

Please, don't forget to add tests in your other PR

Probably, that one (i.e.#133329) should be merged first.

donBarbos and sobolevn reacted with thumbs up emoji

Copy link
Contributor

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some docs notes

donBarbosand others added2 commitsMay 4, 2025 16:46
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Now please rebase this PR and add tests :)

donBarbos reacted with thumbs up emoji
donBarbosand others added2 commitsMay 5, 2025 02:26
…5nl2u.rstCo-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@sobolevnsobolevn requested a review fromhugovkMay 4, 2025 22:47
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One more suggestion: let's add defaults to the docs.

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you! 🎉

@sobolevnsobolevnenabled auto-merge (squash)May 5, 2025 16:55
@sobolevnsobolevn merged commit2b4e2b7 intopython:mainMay 5, 2025
39 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sobolevnsobolevnsobolevn approved these changes

@tomasr8tomasr8tomasr8 left review comments

@picnixzpicnixzpicnixz left review comments

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@hugovkhugovkhugovk approved these changes

@isidenticalisidenticalAwaiting requested review from isidenticalisidentical is a code owner

@Eclips4Eclips4Awaiting requested review from Eclips4Eclips4 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@donBarbos@skirpichev@JelleZijlstra@hugovk@sobolevn@tomasr8@picnixz@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp