Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-132983: Build_zstd on Windows#133366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 7 commits intopython:mainfromAA-Turner:zstandard-pc
May 5, 2025
Merged

Conversation

AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commentedMay 4, 2025•
edited by bedevere-appbot
Loading

Per the documentation inzlib/lib, we buildlib/common,lib/compress,lib/decompress, andlib/dictBuilder.

Buildinglib/legacy is noted as optional to support decompression only of archives created with Zstd 0.8 (2016) or earlier. That release is 10 years old, so for simplicity I chose not to build it, but we could add it in if thought useful.

A

emmatyping and hugovk reacted with hooray emojistonebig reacted with heart emoji
@emmatyping
Copy link
Member

emmatyping commentedMay 4, 2025•
edited
Loading

Oh this is great! I had a branch with similar changes that I hadn't gotten to making a PR, but this looks good! Thank you for proposing it.

Building lib/legacy is noted as optional to support decompression only of archives created with Zstd 0.8 (2016) or earlier. That release is 10 years old, so for simplicity I chose not to build it, but we could add it in if thought useful.

I don't think the current code currently or will use it, so I think it is fine to exclude.

Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

@AA-Turner

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@AA-TurnerAA-Turnerforce-pushed thezstandard-pc branch 3 times, most recently from955650f todf19f59CompareMay 4, 2025 20:27
@AA-Turner

This comment was marked as resolved.

@bedevere-bot

This comment was marked as resolved.

@AA-Turner

This comment was marked as resolved.

@AA-Turner
Copy link
MemberAuthor

cc@zooba -- please could I ask for a quick once-over of the build changes in this PR? I'm fairly confident in them, but would be good to have a review.

A

Copy link
Member

@zoobazooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks fine to me, though I'm not sure we need a separate project forzstd? We should be able to reference all the files directly through_zstd (we couldn't for zlib-ng because their build process is way too complex to integrate intopythoncore, but this one looks pretty simpleand already has its own extension module that's separate).

@emmatyping

This comment was marked as resolved.

@zooba

This comment was marked as resolved.

Copy link
Contributor

@sethmlarsonsethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

SBOM changes LGTM, thank you!

AA-Turner reacted with heart emoji
MSB8027: Two or more files with the name of zdict.c will produce outputs to the same location. This can lead to an incorrect build result.  The files involved are ..\Modules\_zstd\zdict.c, \externals\zstd-1.5.7\lib\dictBuilder\zdict.c.
@AA-TurnerAA-Turner added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 5, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@AA-Turner for commit1ae3a76 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133366%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 5, 2025
Copy link
Member

@zoobazooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Merge whenever you're ready

AA-Turner, emmatyping, and hugovk reacted with hooray emoji
@AA-Turner
Copy link
MemberAuthor

Note for others: because we now buildzstd as one project, we can't have name collisions, so we've renamedModules\zdict.c toModules\zstddict.c.

emmatyping reacted with thumbs up emoji

@AA-TurnerAA-Turner merged commite6f8e0a intopython:mainMay 5, 2025
67 of 75 checks passed
@AA-TurnerAA-Turner deleted the zstandard-pc branchMay 5, 2025 23:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@emmatypingemmatypingemmatyping approved these changes

@zoobazoobazooba approved these changes

@sethmlarsonsethmlarsonsethmlarson approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@AA-Turner@emmatyping@bedevere-bot@zooba@sethmlarson
[8]ページ先頭
©2009-2025 Movatter.jp