NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-133351: Fix Cmd completion for lines beginning with`!`#133362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

godlygeek wants to merge1 commit intopython:mainfromgodlygeek:fix_cmd_bang_completion

Closed

gh-133351: Fix Cmd completion for lines beginning with`!`#133362

godlygeek wants to merge1 commit intopython:mainfromgodlygeek:fix_cmd_bang_completion

Conversation

Copy link

Contributor

godlygeek commentedMay 4, 2025•
edited by bedevere-appbot
Loading

When a line begins with! and there's nodo_shell method defined,parsecmd returnsNone as thecmd, which incorrectly leads toNone being concatenated tocomplete_ and triggering aTypeError.

Instead, recognizeNone as a sentinel that means we should callcompletedefault, as an empty string already is.

Issue:completion for remote pdb is not ideal #133351

Fix Cmd completion for lines beginning with!

d7cc6b4

When a line begins with `!` and there's no `do_shell` method defined,`parsecmd` returns `None` as the `cmd`, which incorrectly leads to`None` being concatenated to `complete_` and triggering a `TypeError`.Instead, recognize `None` as a sentinel that means we should call`completedefault`, as an empty string already is.