NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

gh-131178: Add tests for`ast` command-line interface#133329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sobolevn merged 11 commits intopython:mainfromdonBarbos:issue-131178-ast

May 4, 2025

Merged

gh-131178: Add tests for`ast` command-line interface#133329

sobolevn merged 11 commits intopython:mainfromdonBarbos:issue-131178-ast

May 4, 2025

Conversation

Copy link

Contributor

donBarbos commentedMay 3, 2025•
edited by bedevere-appbot
Loading

Issue:Add tests for command-line interface #131178

Add tests forast command-line interface

198c87a

donBarbos requested review fromEclips4,isidentical andJelleZijlstra ascode owners

May 3, 2025 05:07

bedevere-appbot mentioned this pull request

May 3, 2025

Add tests for command-line interface#131178

Open

9 tasks

bedevere-appbot added the awaiting review label

May 3, 2025

donBarbos added2 commits

May 3, 2025 09:14

check unknown flag output

bc12715

remove unused import

75d3cb7

Eclips4 added the skip news label

May 3, 2025

Eclips4 self-assigned this

May 3, 2025

StanFromIreland reviewed

May 3, 2025

View reviewed changes

Lib/test/test_ast/test_ast.pyShow resolvedHide resolved

tomasr8 reviewed

May 3, 2025

View reviewed changes

Lib/test/test_ast/test_ast.pyShow resolvedHide resolved

Lib/test/test_ast/test_ast.py OutdatedShow resolvedHide resolved

Accept suggestions

de328af

Eclips4 approved these changes

May 4, 2025

View reviewed changes

Copy link

Member

Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks!

bedevere-appbot added awaiting merge and removed awaiting review labels

May 4, 2025

sobolevn reviewed

May 4, 2025

View reviewed changes

Copy link

Member

sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please, also test that-h and--help works.

Lib/ast.py OutdatedShow resolvedHide resolved

Lib/test/test_ast/test_ast.py OutdatedShow resolvedHide resolved

Lib/test/test_ast/test_ast.pyShow resolvedHide resolved

Accept suggestions

6aa5cd7

sobolevn reviewed

May 4, 2025

View reviewed changes

Lib/test/test_ast/test_ast.py OutdatedShow resolvedHide resolved

donBarbos added2 commits

May 4, 2025 15:35

accept again

b804f61

Rename from flags to flag

21097eb

skirpichev mentioned this pull request

May 4, 2025

gh-133367: Add missing options toast CLI#133369

Merged

Rewrite tests with help messages

42ff309

JelleZijlstra reviewed

May 4, 2025

View reviewed changes

Lib/test/test_ast/test_ast.py OutdatedShow resolvedHide resolved

Remove normalize for result

ac71310

sobolevn reviewed

May 4, 2025

View reviewed changes

Copy link

Member

sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

two minor things :)

Lib/test/test_ast/test_ast.py OutdatedShow resolvedHide resolved

donBarbosand others added2 commits

May 5, 2025 00:45

Update test_ast.py

9f6f5b2

Update test_ast.py

361706a

Co-authored-by: sobolevn <mail@sobolevn.me>

sobolevn approved these changes

May 4, 2025

View reviewed changes

Copy link

Member

sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thank you!

sobolevnenabled auto-merge (squash)

May 4, 2025 20:56

Copy link

ContributorAuthor

donBarbos commentedMay 4, 2025

Thank you everyone

sobolevn merged commit6ce60f1 intopython:main

May 4, 2025

38 checks passed

bedevere-appbot removed the awaiting merge label

May 4, 2025

diegorusso added a commit to diegorusso/cpython that referenced this pull request

May 4, 2025

Merge remote-tracking branch 'origin/main' into call-len

c03babc

* origin/main: (111 commits)pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385)pythongh-131178: Add tests for `ast` command-line interface (python#133329)  Regenerate pcbuild.sln in Visual Studio 2022 (python#133394)pythongh-133042: disable HACL* HMAC on Emscripten (python#133064)pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387)pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946)pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388)pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830)pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368)pythongh-132457: make staticmethod and classmethod generic (python#132460)pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812)pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490)pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517)pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628)pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358)  bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226)pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287)pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364)pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027)pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284)  ...