Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Docs: standardize boolean constants instdtypes.rst#133325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Yzi-Li
Copy link
Contributor

@Yzi-LiYzi-Li commentedMay 3, 2025•
edited by github-actionsbot
Loading

Replaces lowercasetrue/false with standard boolean valuesTrue/False.

📚 Documentation preview 📚:https://cpython-previews--133325.org.readthedocs.build/

@skirpichev
Copy link
Contributor

@Yzi-Li, please avoid using "Update branch" button, unless you do something meaningful, e.g. fix a merge conflict.

@Yzi-Li
Copy link
ContributorAuthor

Sorry, but I just want to revert the commit.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There are similar cases foris_valid() inDoc/library/string.rst andfilter() inDoc/library/logging.rst. Do you mind to fix them too?

@Yzi-Li
Copy link
ContributorAuthor

Do you mind to fix them too?

I'd like to do.

@Yzi-LiYzi-Li requested a review fromvsajip as acode ownerMay 9, 2025 10:44
@hugovkhugovk added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 9, 2025
@Yzi-Li
Copy link
ContributorAuthor

base64.b85encode() has a boolean parameterpad. In the description of this function, we used "Ifpad is true". Butpad here is a boolean, it must beTrue orFalse. And in other descriptions likeb64decode(), we used "Ifvaliadate isTrue".

Should we useTrue to standardize them?

@serhiy-storchaka
Copy link
Member

No, we should not use this for parameters, because arguments can also be1,0,None, etc.

Yzi-Li reacted with heart emoji

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

@serhiy-storchakaserhiy-storchaka merged commit076004a intopython:mainMay 9, 2025
28 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMay 9, 2025
@miss-islington-app
Copy link

Thanks@Yzi-Li for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 9, 2025
)(cherry picked from commit076004a)Co-authored-by: Yongzi Li <1538321957@qq.com>
@bedevere-app
Copy link

GH-133760 is a backport of this pull request to the3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 9, 2025
)(cherry picked from commit076004a)Co-authored-by: Yongzi Li <1538321957@qq.com>
@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 9, 2025
@bedevere-app
Copy link

GH-133761 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 9, 2025
@Yzi-LiYzi-Li deleted the standardize-bool-in-doc branchMay 9, 2025 14:13
@serhiy-storchaka
Copy link
Member

Thank you for your contribution,@Yzi-Li.

serhiy-storchaka pushed a commit that referenced this pull requestMay 9, 2025
…3325) (GH-133760)(cherry picked from commit076004a)Co-authored-by: Yongzi Li <1538321957@qq.com>
serhiy-storchaka pushed a commit that referenced this pull requestMay 9, 2025
…3325) (GH-133761)(cherry picked from commit076004a)Co-authored-by: Yongzi Li <1538321957@qq.com>
@Yzi-Li
Copy link
ContributorAuthor

I'm glad I could contribute in this way. 😄

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@skirpichevskirpichevskirpichev left review comments

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@vsajipvsajipAwaiting requested review from vsajip

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip issueskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@Yzi-Li@skirpichev@serhiy-storchaka@StanFromIreland@hugovk@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp