May 2, 2025 · May 2, 2025 · May 2, 2025 · May 2, 2025 · May 4, 2025 · May 4, 2025
diff --git a/Lib/email/mime/image.py b/Lib/email/mime/image.py

 from email import encoders
 from email.mime.nonmultipart import MIMENonMultipart
 import base64
 from textwrap import wrap


 class MIMEImage(MIMENonMultipart):
            raise TypeError('Could not guess image MIME subtype')
        MIMENonMultipart.__init__(self, 'image', _subtype, policy=policy,
                                  **_params)
        self.set_payload(_imagedata)
        _encoder(self)

        #self.set_payload(_imagedata)
        #_encoder(self)
        # 1) Turn your image bytes into one long Base64 string
        b64str = base64.b64encode(_imagedata).decode('ascii')

        # 2) Ask the policy “how long should each line be?”
        maxlen = getattr(self.policy, 'max_line_length', 76)

        # 3) Break that long string into chunks of that length
        wrapped = "\r\n".join(wrap(b64str, maxlen))

        # 4) Give the email library those nice, wrapped lines
        self.set_payload(wrapped, 'base64', policy=self.policy)

 _rules = []

diff --git a/Misc/NEWS.d/next/133311.rst b/Misc/NEWS.d/next/133311.rst
 Fix email.mime.image.MIMEImage to respect policy.max_line_length (bpo-133311).
diff --git a/Misc/NEWS.d/next/Library/2025-05-02-23-35-26.gh-issue-133311.c36IjF.rst b/Misc/NEWS.d/next/Library/2025-05-02-23-35-26.gh-issue-133311.c36IjF.rst
 Fix email.mime.image.MIMEImage to respect policy.max_line_length when Base64-encoding image payloads.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -8,6 +8,8 @@

		from email import encoders
		from email.mime.nonmultipart import MIMENonMultipart
		import base64
Copy link Contributor Wulian233May 4, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. It's best to sort the imports, although there won't be any negative impact if we don't do so :) Copy link Contributor abhi-jhaMay 4, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Does this repo allow some sort of pre-commit? Like isort and blake hooks. Those things can help do this automatically. Copy link Contributor abhi-jhaMay 4, 2025• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Wait, I do see a pre-commit setup :https://github.com/python/cpython/blob/main/.pre-commit-config.yaml The CIs don't seem to be imposing these? Linter failures :https://github.com/python/cpython/actions/runs/14805087091/job/41571892036?pr=133322
		from textwrap import wrap
Copy link Member ZeroIntensityMay 11, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. `base64` and`textwrap` are expensive imports. It might be a good idea to move them to the method to reduce import time.


		class MIMEImage(MIMENonMultipart):
Expand DownExpand Up		@@ -39,9 +41,19 @@ def __init__(self, _imagedata, _subtype=None,
		raise TypeError('Could not guess image MIME subtype')
		MIMENonMultipart.__init__(self, 'image', _subtype, policy=policy,
		**_params)
		self.set_payload(_imagedata)
		_encoder(self)

		#self.set_payload(_imagedata)
Copy link Contributor abhi-jhaMay 3, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Should we remove these comments? dkg reacted with thumbs up emoji
		#_encoder(self)
		# 1) Turn your image bytes into one long Base64 string
		b64str = base64.b64encode(_imagedata).decode('ascii')

		# 2) Ask the policy “how long should each line be?”
		maxlen = getattr(self.policy, 'max_line_length', 76)

		# 3) Break that long string into chunks of that length
		wrapped = "\r\n".join(wrap(b64str, maxlen))

		# 4) Give the email library those nice, wrapped lines
		self.set_payload(wrapped, 'base64', policy=self.policy)

		_rules = []

Expand Down
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix email.mime.image.MIMEImage to respect policy.max_line_length (bpo-133311).