Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-53950: ClearMESSAGES in msgfmt#133316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
StanFromIreland wants to merge4 commits intopython:main
base:main
Choose a base branch
Loading
fromStanFromIreland:msgfmt-clear

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIrelandStanFromIreland commentedMay 2, 2025•
edited by bedevere-appbot
Loading

@tomasr8
Copy link
Member

What would be even better is not having a global variable at all, though that would be a larger change and is already partially covered by#10875 I believe.

@StanFromIreland
Copy link
ContributorAuthor

We can just clear it for now, till the larger change is merged.

@StanFromIreland
Copy link
ContributorAuthor

Also request@serhiy-storchaka

@merwok
Copy link
Member

I am unsure about the better fix here. Why not eliminate the global variable if that fixes the problem? Then it will make the other PR smaller.

@StanFromIreland
Copy link
ContributorAuthor

@merwok I updated the PR with that if that is what you prefer, it is not too bad, the diff is pretty low.

@serhiy-storchaka
Copy link
Member

Sharing MESSAGES between files is a (mis-)feature. See#10875 which solves this problem more thoroughly.

@StanFromIreland
Copy link
ContributorAuthor

Do you mind splitting it from the larger pr, it would simplify it as Eric mentioned.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tomasr8tomasr8tomasr8 approved these changes

@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

@merwokmerwokAwaiting requested review from merwok

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@StanFromIreland@tomasr8@merwok@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp