Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-133306: Support \z as a synonym for \Z in regular expressions#133314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks Serhiy. I only had one thought on this PR:
Lib/re/_parser.py Outdated
| @@ -49,7 +49,8 @@ | |||
| r"\S": (IN, [(CATEGORY, CATEGORY_NOT_SPACE)]), | |||
| r"\w": (IN, [(CATEGORY, CATEGORY_WORD)]), | |||
| r"\W": (IN, [(CATEGORY, CATEGORY_NOT_WORD)]), | |||
| r"\Z": (AT, AT_END_STRING), # end of string | |||
| r"\z": (AT, AT_END_STRING), # end of string | |||
| r"\Z": (AT, AT_END_STRING), # end of string (deprecated) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we use "deprecated" language here if we're not deprecating\Z?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What words do you suggest? "legacy"? "obsolete"?
Due to its subtle difference from other common implementations, it is very likely that\Z will be deprecated and removed in future, when it will be safe. It is kept for compatibility with older Python versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for the PR! Please also run the buildbots before merge.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Thank you for review. This feature is not platform-depended, so no need to spend the time and the resources on running the buildbots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
ac56f8c intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--133314.org.readthedocs.build/