Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133253: making linecache thread-safe#133305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

vfdev-5
Copy link
Contributor

@vfdev-5vfdev-5 commentedMay 2, 2025•
edited
Loading

Fixes#133253

Description:

  • Making linecache thread-safe

cc@colesbury

@python-cla-bot
Copy link

python-cla-botbot commentedMay 2, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Copy link
Contributor

@hawkinsphawkinsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consider checking in your tests, somewhere?

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@vfdev-5vfdev-5force-pushed themake-linecache-threadsafe branch 3 times, most recently from690f5a8 toff93d54CompareMay 5, 2025 10:46
@vfdev-5vfdev-5 marked this pull request as ready for reviewMay 5, 2025 10:46
@vfdev-5
Copy link
ContributorAuthor

@rhettinger could you please review this PR fixing the data race in linecache (issue 133253) or suggest a right person for the code review. Thanks!

@colesburycolesbury requested a review fromrhettingerMay 5, 2025 15:46
Copy link
Contributor

@colesburycolesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This LGTM, but I'd appreciate@rhettinger's review

@vfdev-5vfdev-5force-pushed themake-linecache-threadsafe branch fromff93d54 tof4fe446CompareMay 5, 2025 19:21
@kumaraditya303kumaraditya303 merged commit8054184 intopython:mainMay 9, 2025
39 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hawkinsphawkinsphawkinsp requested changes

@colesburycolesburycolesbury approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@rhettingerrhettingerAwaiting requested review from rhettinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race in linecache under free-threading
4 participants
@vfdev-5@hawkinsp@colesbury@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp