Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-126008: Improve docstrings for Tkinter cget and configure methods#133303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedMay 2, 2025•
edited by bedevere-appbot
Loading

  • Explain the behavior of Widget.configure() depending on arguments.
  • Unify descriptions.
  • Replace "resource" with "option".

…thods* Explain the behavior of Widget.configure() depending on arguments.* Unify descriptions.* Replace "resource" with "option".
terryjreedy
terryjreedy previously requested changesMay 3, 2025
@bedevere-app
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14bugs and security fixes labelMay 8, 2025
@serhiy-storchakaserhiy-storchaka requested a review froma teamMay 13, 2025 10:36
@terryjreedyterryjreedy dismissed theirstale reviewAugust 11, 2025 21:21

We agree that it would be better to have a separate issue/PR to handle option name formatting in docstrings in this entire file.

@serhiy-storchakaserhiy-storchaka merged commit027cacb intopython:mainAug 12, 2025
43 of 44 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsAug 12, 2025
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@serhiy-storchakaserhiy-storchaka deleted the docs-tkinter-configure branchAugust 12, 2025 04:55
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 12, 2025
…thods (pythonGH-133303)* Explain the behavior of Widget.configure() depending on arguments.* Unify descriptions.* Replace "resource" with "option".(cherry picked from commit027cacb)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 12, 2025
…thods (pythonGH-133303)* Explain the behavior of Widget.configure() depending on arguments.* Unify descriptions.* Replace "resource" with "option".(cherry picked from commit027cacb)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-137660 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelAug 12, 2025
@bedevere-app
Copy link

GH-137661 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelAug 12, 2025
serhiy-storchaka added a commit that referenced this pull requestAug 12, 2025
…ethods (GH-133303) (GH-137661)* Explain the behavior of Widget.configure() depending on arguments.* Unify descriptions.* Replace "resource" with "option".(cherry picked from commit027cacb)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka
Copy link
MemberAuthor

Thank you for your review,@terryjreedy,@bskinn.

bskinn reacted with thumbs up emoji

maurycy added a commit to maurycy/cpython that referenced this pull requestAug 12, 2025
* main:pythongh-137288: Update 3.14 magic numbers (pythonGH-137665)pythongh-135228: When@DataClass(slots=True) replaces a dataclass, make the original class collectible (take 2) (pythonGH-137047)pythongh-126008: Improve docstrings for Tkinter cget and configure methods (pythonGH-133303)pythongh-131885: Use positional-only markers for ``max()`` and ``min()`` (python#131868)pythonGH-137426: Remove code deprecation of `importlib.abc.ResourceLoader` (pythonGH-137567)pythongh-125897: Mark range function parameters as positional only (python#125945)pythongh-137400: Fix a crash when disabling profiling across all threads (pythongh-137471)pythongh-115766: Fix IPv4Interface.is_unspecified (pythonGH-137326)pythongh-128813: cleanup C-API docs for PyComplexObject (pythonGH-137579)pythongh-135953: Profile a module or script with sampling profiler (python#136777)  Fix documentation of hash in PyHash_FuncDef (python#137595)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull requestAug 19, 2025
…thods (pythonGH-133303)* Explain the behavior of Widget.configure() depending on arguments.* Unify descriptions.* Replace "resource" with "option".
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tomasr8tomasr8tomasr8 left review comments

@AA-TurnerAA-TurnerAA-Turner left review comments

@terryjreedyterryjreedyterryjreedy left review comments

+1 more reviewer

@bskinnbskinnbskinn left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@serhiy-storchaka@tomasr8@AA-Turner@bskinn@terryjreedy
[8]ページ先頭
©2009-2025 Movatter.jp