Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-132983: [Draft] Run refleak tests against _zstd with tests#133282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This commit introduces the `_zstd` module, with bindings to libzstd fromthe pyzstd project. It also includes the unix build system configuration.Windows build system support will be integrated independently as itdepends on integration with cpython-source-deps.
Also removes module state references from the classes in the _zstdmodule and instead uses PyType_GetModuleState()
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
This should avoid races and deadlocks.
The `compress`/`decompress` functions will be moved to Python code for simplicity.C implementations can always be re-added in the future.Also, mark _zstd as not requiring the GIL.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
... for `get_zstd_state_from_type`Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
PyModule_AddObject is soft-deprecated, so we should use PyModule_AddObjectRef
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
We should instead document that to pickle a dictionary a user should usethe `.dict_content` attribute.
bedevere-bot commentedMay 2, 2025
🤖 New build scheduled with the buildbot fleet by@emmatyping for commit65542c4 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133282%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again. |
bedevere-bot commentedMay 2, 2025
🤖 New build scheduled with the buildbot fleet by@emmatyping for commit6328860 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133282%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again. |
Uh oh!
There was an error while loading.Please reload this page.
Wanted to see the results of running the refleak tests against the module using GC.
📚 Documentation preview 📚:https://cpython-previews--133282.org.readthedocs.build/