NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

[3.7] Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)"#13328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:3.7fromvstinner:revert_asyncio_ssl37

May 14, 2019

Merged

[3.7] Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)"#13328

vstinner merged 1 commit intopython:3.7fromvstinner:revert_asyncio_ssl37

May 14, 2019

Conversation

Copy link

Member

vstinner commentedMay 14, 2019•
edited by bedevere-bot
Loading

This reverts commit93aa57a.

https://bugs.python.org/issue36801

Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL …

ce31447

…transport (GH-13098)"This reverts commit93aa57a.

vstinner requested review from1st1,asvetlov andgpshead ascode owners

May 14, 2019 20:04

the-knights-who-say-ni added the CLA signed label

May 14, 2019

bedevere-bot added the awaiting core review label

May 14, 2019

vstinner changed the title~~Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)"~~[3.7] Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)"

May 14, 2019

Copy link

MemberAuthor

vstinner commentedMay 14, 2019

The revert is motivated byhttps://bugs.python.org/issue36870 : test_asyncio fails randomly which causes a lot of pain in the Python CI and the Python workflow. See:
https://bugs.python.org/issue36870#msg342509

asvetlov approved these changes

May 14, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

May 14, 2019

Copy link

Contributor

asvetlov commentedMay 14, 2019•
edited
Loading

I guess the reversion PR should be backported to 3.7 as well

UPD.
Sorry, I mean master.

This PR is a reversion for#13176 on 3.7
#13098 should be reverted on the master too

Copy link

MemberAuthor

vstinner commentedMay 14, 2019

I guess the reversion PR should be backported to 3.7 as well

This revert is for Python 3.7.

Copy link

Contributor

asvetlov commentedMay 14, 2019

Sorry, I mean the same code should be reverted on the master too

Copy link

MemberAuthor

vstinner commentedMay 14, 2019

Without this change, I easily reproduce the failure on Windows:

vstinner@WIN C:\vstinner\python\3.7>python -m test test_asyncio -m test_drain_raises -v(...)test_drain_raises (test.test_asyncio.test_streams.StreamTests) ... Warning -- threading_cleanup() failed to cleanup 0 threads (count: 0, dangling: 2)     Dangling thread: <Thread(Thread-1, stopped daemon 1568)>Dangling thread: <_MainThread(MainThread, started 1244)>ERROR======================================================================ERROR: test_drain_raises (test.test_asyncio.test_streams.StreamTests)----------------------------------------------------------------------Traceback (most recent call last):  File "C:\vstinner\python\3.7\lib\test\test_asyncio\test_streams.py", line 820, in test_drain_raises    self.loop.run_until_complete(client(*addr))  File "C:\vstinner\python\3.7\lib\asyncio\base_events.py", line 584, in run_until_complete    return future.result()  File "C:\vstinner\python\3.7\lib\test\test_asyncio\test_streams.py", line 810, in client    await writer.drain()  File "C:\vstinner\python\3.7\lib\asyncio\streams.py", line 351, in drain    await fut  File "C:\vstinner\python\3.7\lib\asyncio\selector_events.py", line 860, in write    n = self._sock.send(data)ConnectionAbortedError: [WinError 10053] An established connection was aborted by the software in your host machine(...)

With this change, the test pass as expected:

vstinner@WIN C:\vstinner\python\3.7>python -m test test_asyncio -m test_drain_raises -v(...)test_drain_raises (test.test_asyncio.test_streams.StreamTests) ... ok(...)Tests result: SUCCESS