NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-133261: Use __builtin_frame_address() on GCC 9 and older#133269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:mainfromvstinner:builtin_frame_address

May 1, 2025

Merged

gh-133261: Use __builtin_frame_address() on GCC 9 and older#133269

vstinner merged 1 commit intopython:mainfromvstinner:builtin_frame_address

May 1, 2025

Conversation

Copy link

Member

vstinner commentedMay 1, 2025•
edited by bedevere-appbot
Loading

GCC 9 and older don't have __has_builtin(), but have __builtin_frame_address() function.

Issue:test_frame does crash randomly on Linux (x86-64, ppc64le, s390x) #133261

pythongh-133261: Use __builtin_frame_address() on GCC 9 and older

f6ef2e3

GCC 9 and older don't have __has_builtin(), but have__builtin_frame_address() function.

vstinner added the skip news label

May 1, 2025

vstinner requested a review fromericsnowcurrently as acode owner

May 1, 2025 16:45

bedevere-appbot mentioned this pull request

May 1, 2025

test_frame does crash randomly on Linux (x86-64, ppc64le, s390x)#133261

Closed

bedevere-appbot added the awaiting core review label

May 1, 2025

Copy link

MemberAuthor

vstinner commentedMay 1, 2025

Without this change, test_frame crash randomly (ex: at the 3rd attempt).

With this change, test_frame no longer crash. I ran the test in a loop using./python -m test test_frame -F and interrupted the test after 54 successful iterations.

Copy link

Contributor

ambv commentedMay 1, 2025•
edited
Loading

Unsurprisingly, on Windows 11 with a different compiler and this PR applied, running-m test test_frame -F is still crashing with a stack overflow. That will need a different fix.