NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

GH-133231: Add JIT utilities in`sys._jit`#133233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

brandtbucher merged 17 commits intopython:mainfrombrandtbucher:sys-jit

May 5, 2025

Merged

GH-133231: Add JIT utilities in`sys._jit`#133233

brandtbucher merged 17 commits intopython:mainfrombrandtbucher:sys-jit

May 5, 2025

Conversation

Copy link

Member

brandtbucher commentedMay 1, 2025•
edited by github-actionsbot
Loading

Issue:Add JIT utilities insys._jit #133231

📚 Documentation preview 📚:https://cpython-previews--133233.org.readthedocs.build/

brandtbucher added5 commits

April 30, 2025 19:15

Add sys._jit

d67c2a7

blurb add

ba56202

fixup

5a6f11f

fixup

5b27d20

fixup

080fd51

brandtbucher added type-feature

A feature request or enhancement

interpreter-core

(Objects, Python, Grammar, and Parser dirs)

topic-JIT labels

May 1, 2025

brandtbucher self-assigned this

May 1, 2025

brandtbucher requested review fromericsnowcurrently andmarkshannon ascode owners

May 1, 2025 02:24

bedevere-appbot added the awaiting core review label

May 1, 2025

bedevere-appbot mentioned this pull request

May 1, 2025

Add JIT utilities insys._jit#133231

Closed

AA-Turner reviewed

May 1, 2025

View reviewed changes

Copy link

Member

AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

quick doc-only review:

Doc/library/sys.rst OutdatedShow resolvedHide resolved

Doc/using/cmdline.rst

Comment on lines +1284 to +1290

		.. envvar:: PYTHON_JIT

		On builds where experimental just-in-time compilation is available, this
		variable can force the JIT to be disabled (``0``) or enabled (``1``) at
		interpreter startup.

		.. versionadded:: 3.13

Copy link

Member

AA-TurnerMay 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should backport this, should it be split out into a different PR for ease?

Copy link

MemberAuthor

brandtbucherMay 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We can just backport it separately, since I need the ref for this PR's changes.

Copy link

Member

AA-TurnerMay 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is it worth using miss-islington for the backport here?

Copy link

MemberAuthor

brandtbucherMay 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'll just do it manually in a bit.

Fix failing test

1b2e511

Copy link

MemberAuthor

brandtbucher commentedMay 1, 2025

I just realized that my approach forsys._jit.is_active() will need reworking, since the tail-calling interpreter doesn't haveentry_frame handy.

brandtbucher added4 commits

May 1, 2025 10:24

Feedback from code review

775eb32

Merge branch 'main' into sys-jit

1c4f440

Fix references

db7609f

Rework sys._jit.is_active to support the tail-calling interpreter

fc4824b

Copy link

MemberAuthor

brandtbucher commentedMay 1, 2025

Okay, reworked to support tail-calling.

Fix JIT interpreter

b80bdf8

Copy link

MemberAuthor

brandtbucher commentedMay 2, 2025

@markshannon, let me know what you think. The bots won't let us merge features without approving review, but I'd like to get something like this in before the freeze.