Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-132969: Fix error/hang when shutdown(wait=False) and task exited abnormally#133222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ogbiggles wants to merge26 commits intopython:main
base:main
Choose a base branch
Loading
fromogbiggles:origin/main
Open
Changes from1 commit
Commits
Show all changes
26 commits
Select commitHold shift + click to select a range
8ac1fcf
gh-132969 Fix exception/hang when shutdown(wait=False) and a task ex…
ogbigglesApr 30, 2025
1774445
📜🤖 Added by blurb_it.
blurb-it[bot]Apr 30, 2025
0938eeb
gh-132969 Skip forkserver-dependent test on Windows
blurb-it[bot]Apr 30, 2025
dbc0ba8
Merge branch 'origin/main' of github.com:ogbiggles/cpython-fix-132969…
ogbigglesApr 30, 2025
99ab321
gh-132969 Skip forkserver dependent tests on Windows
ogbigglesApr 30, 2025
fe3650c
Merge branch 'main' into origin/main
ogbigglesApr 30, 2025
40cefc2
Merge branch 'python:main' into origin/main
ogbigglesMay 8, 2025
c177c91
gh-132969 Added more verbiage to the explanation.
ogbigglesMay 9, 2025
2cd70b1
gh-132969 Add more verbiage explaining the change
ogbigglesMay 9, 2025
57265b5
gh-132969 Make test helper methods into private class methods, use @…
ogbigglesMay 9, 2025
d0c2bb0
Merge branch 'origin/main' of github.com:ogbiggles/cpython-fix-132969…
ogbigglesMay 9, 2025
709d9fd
gh-132969 Fix Sphinx Lint error
ogbigglesMay 9, 2025
1a8919b
gh-132969: make unittest for gh-132969 runnable on windows by swichin…
ogbigglesMay 9, 2025
87eb623
gh-132969: Remove @unittest.skipIf annotations since spawn works on w…
ogbigglesMay 9, 2025
ec2543a
gh-132969: Incorproate review suggestion to skip test when start_meth…
ogbigglesMay 9, 2025
3b3721f
gh-132969: Remove import of multiprocessing and use self.get_context(…
ogbigglesMay 9, 2025
7ef7872
gh-132969: use self.skipTest instead of unittest.SkipTest, shorten me…
ogbigglesMay 9, 2025
efd0a1d
gh-132969: removed type annotations
ogbigglesMay 9, 2025
b335d38
gh-132969: removed extraneous blank line
ogbigglesMay 9, 2025
b060786
gh-132969: fix call to self.skipTest
ogbigglesMay 9, 2025
c6457c3
gh-132969: Run gh-132969 tests only with "spawn" mp_context
ogbigglesMay 12, 2025
2beb0d9
Merge branch 'main' into origin/main
ogbigglesMay 12, 2025
65f30b0
gh-132969: Join executor_manager_thread after exercising shutdown(wai…
ogbigglesMay 12, 2025
54ae7b8
gh-132969: fix typo in skip message
ogbigglesMay 12, 2025
e132f5e
gh-132969: Tweak the news entry for grammar and clarity.
ogbigglesMay 12, 2025
9908810
gh-132969: Run test with "spawn" on all platforms and "forkserver" if…
ogbigglesMay 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
gh-132969: Join executor_manager_thread after exercising shutdown(wai…
…t=False) to prevent resource leak when running CI
  • Loading branch information
@ogbiggles
ogbiggles committedMay 12, 2025
commit65f30b0d23abbaed0043836470c7698c9a939ff3
7 changes: 6 additions & 1 deletionLib/test/test_concurrent_futures/test_shutdown.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -339,7 +339,7 @@ def _good_task_gh_132969(cls, n):
time.sleep(0.1 * n)
return n

def _run_test_issue_gh_132969(self, max_workers: int) -> int:
def _run_test_issue_gh_132969(self, max_workers):
# max_workers=2 will repro exception
# max_workers=4 will repro exception and then hang

Expand All@@ -366,7 +366,12 @@ def _run_test_issue_gh_132969(self, max_workers: int) -> int:
# stop processing results upon first exception
pass

# Ensure that the executor cleans up after called
# shutdown with wait=False
executor_manager_thread = executor._executor_manager_thread
executor.shutdown(wait=False)
time.sleep(0.2)
executor_manager_thread.join()
return result

def test_shutdown_gh_132969_case_1(self):
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp