Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133117: Enable stricter mypy checks fortomllib#133206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 1 commit intopython:mainfromsobolevn:issue-133117-2
May 3, 2025

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedApr 30, 2025•
edited
Loading

@AlexWaygood
Copy link
Member

I support this but I'm not sure if it makes sense to merge it prior tohukkin/tomli#257? Might it not cause problems if the two codebases get out of sync?

I'll defer to@hukkin /@hauntsaninja /@encukou as the tomllib maintainers :-)

@AlexWaygoodAlexWaygood removed their request for reviewApril 30, 2025 13:39
@sobolevn
Copy link
MemberAuthor

hukkin/tomli#257 was merged. The only difference with this PR is that here we still use--incremental, I think it is more important for us, since the scale of the project and the fact that we don't have any extra configs.

cc@hukkin

@sobolevn
Copy link
MemberAuthor

Going to merge this tomorrow :)

@sobolevnsobolevn merged commitcb31741 intopython:mainMay 3, 2025
53 checks passed
@miss-islington-app
Copy link

Thanks@sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 3, 2025
…133206)(cherry picked from commitcb31741)Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

GH-133343 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 3, 2025
sobolevn added a commit that referenced this pull requestMay 3, 2025
… (#133343)gh-133117: Enable stricter mypy checks for `tomllib` (GH-133206)(cherry picked from commitcb31741)Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@encukouencukouAwaiting requested review from encukouencukou is a code owner

@hauntsaninjahauntsaninjaAwaiting requested review from hauntsaninjahauntsaninja is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sobolevn@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp