Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-131747: ctypes: Deprecate _pack_ implicitly setting _layout_ = 'ms'#133205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
bedevere-bot commentedMay 2, 2025
🤖 New build scheduled with the buildbot fleet by@encukou for commit85cee9f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133205%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
@ZeroIntensity, would you mind doing a quick review? |
ZeroIntensity approved these changesMay 5, 2025
Uh oh!
There was an error while loading.Please reload this page.
Comment on lines +343 to +344
| if MS_WINDOWS: | ||
| warn_context = contextlib.nullcontext() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why not just skip the test on Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We want to this towork everywhere (but warn only on non-Windows).
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
59f78d7 intopython:main 39 checks passed
Uh oh!
There was an error while loading.Please reload this page.
bedevere-bot commentedMay 5, 2025
|
That failure was a timeout; the next builds passed. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Deprecate the silent layout switch, plan removal in 3.19 as per PEP 387.
Leave Windows alone; there's plenty of Windows-only ctypes code where this would just be noise.
📚 Documentation preview 📚:https://cpython-previews--133205.org.readthedocs.build/