Movatterモバイル変換

Skip to content

python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-133197: Improve error message for`ft""` and`bt""` cases#133202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

sobolevn merged 4 commits intopython:mainfromsobolevn:issue-133196

Apr 30, 2025

Merged

gh-133197: Improve error message for`ft""` and`bt""` cases#133202

sobolevn merged 4 commits intopython:mainfromsobolevn:issue-133196

Apr 30, 2025

Conversation

sobolevn

Copy link

Member

sobolevn commentedApr 30, 2025•
edited
Loading

Issue:Improve error message for strings with conflicting prefixes #133197

@sobolevn

pythongh-133196: Improve error message forft""case

4f57f3d

@sobolevn

sobolevn requested review frompablogsal andlysnikolaou ascode owners

April 30, 2025 11:39

@bedevere-app

bedevere-appbot added the awaiting core review label

@bedevere-app

bedevere-appbot mentioned this pull request

PEP 750 changes do no guard for usage with older versions likeast.parse(t'', feature_version=(3, 13))#133196

Closed

@sobolevn

sobolevn added the skip news label

@sobolevn

Copy link

MemberAuthor

sobolevn commentedApr 30, 2025

Hm, looks like other string prefixes can also conflict with no clear message. Examples:

>>>tb''File"<python-input-3>",line1tb''^^SyntaxError:invalidsyntax>>>fb''File"<python-input-0>",line1fb''^^SyntaxError:invalidsyntax>>>ru''File"<python-input-1>",line1ru''^^SyntaxError:invalidsyntax>>>bu''File"<python-input-2>",line1bu''^^SyntaxError:invalidsyntax

Let's handle allt cases here maybe andu-string prefixes in the next PR? It would much easier for me.

@sobolevn

Also handletb cases

b269ebb

@sobolevn

sobolevn changed the title~~gh-133196: Improve error message forft"" case~~gh-133196: Improve error message forft"" andbt"" cases

DangNhutNguyen

DangNhutNguyen approved these changes

View reviewed changes

lysnikolaou

lysnikolaou reviewed

View reviewed changes

Copy link

Member

lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Left a couple of comments inline. Also, it appears that the issue number is wrong. Could you change it please?

Lib/test/test_syntax.py OutdatedShow resolvedHide resolved

Parser/lexer/lexer.c OutdatedShow resolvedHide resolved

@sobolevn

Address review

40668a5

@sobolevn

Copy link

MemberAuthor

sobolevn commentedApr 30, 2025

Now we have prefixes highlighted:

@sobolevn

sobolevn changed the title~~gh-133196: Improve error message forft"" andbt"" cases~~gh-133197: Improve error message forft"" andbt"" cases

@bedevere-app

bedevere-appbot mentioned this pull request

Improve error message for strings with conflicting prefixes#133197

Closed

@sobolevn

together

a4aa4c0

lysnikolaou

lysnikolaou approved these changes

View reviewed changes

Copy link

Member

lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! This is a nice improvement! Let's follow up with the rest of the prefixes.

@bedevere-app

bedevere-appbot added awaiting merge and removed awaiting core review labels

@sobolevn

sobolevn merged commitb451516 intopython:main

45 checks passed

@bedevere-app

bedevere-appbot removed the awaiting merge label

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

3 participants

@sobolevn

@lysnikolaou

@DangNhutNguyen

[8]ページ先頭

©2009-2025 Movatter.jp