Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Apply 'mod' role to typing module#133201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 2 commits intopython:mainfromrffontenelle:patch-8
Apr 30, 2025
Merged

Conversation

rffontenelle
Copy link
Contributor

@rffontenellerffontenelle commentedApr 30, 2025•
edited by github-actionsbot
Loading

To highlight the fact that "typing" is the module name, which e.g. would reduce the chance of an incorrect translation when translating Python docs.

📚 Documentation preview 📚:https://cpython-previews--133201.org.readthedocs.build/

@AlexWaygood
Copy link
Member

Could we use

:mod:`!typing`

rather than

:mod:`typing`

Otherwise Sphinx will add a link that just takes the reader to the page they're already on, which seems annoying/distracting

JelleZijlstra reacted with thumbs up emoji

@AA-TurnerAA-Turnerenabled auto-merge (squash)April 30, 2025 16:49
@AA-TurnerAA-Turner merged commit2b67db7 intopython:mainApr 30, 2025
28 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsApr 30, 2025
@miss-islington-app
Copy link

Thanks@rffontenelle for the PR, and@AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 30, 2025
(cherry picked from commit2b67db7)Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

GH-133217 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 30, 2025
@rffontenellerffontenelle deleted the patch-8 branchApril 30, 2025 16:53
AA-Turner added a commit that referenced this pull requestApr 30, 2025
Apply 'mod' role to typing module (GH-133201)(cherry picked from commit2b67db7)Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@Yzi-Li
Copy link
Contributor

Yzi-Li commentedMay 2, 2025•
edited
Loading

I found the title oftyping is

:mod:`typing`

Shoud we use

:mod:`!typing`

like other modules?

I did it in#133283.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip issueskip newstopic-typing
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@rffontenelle@AlexWaygood@Yzi-Li@AA-Turner
[8]ページ先頭
©2009-2025 Movatter.jp