Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove redundant incref of immortal object Py_EMPTY_KEYS#133200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
methane merged 3 commits intopython:mainfrombiglizards:remove-pointless-incref
Apr 30, 2025

Conversation

biglizards
Copy link
Contributor

Py_EMPTY_KEYS is immortal, sodictkeys_incref will always return without doing anything. The file used to contain two instances ofdictkeys_incref(Py_EMPTY_KEYS); one was removed inthis PR.

I understand this to be a trivial change, and as such haven't made an issue for it. The blurb tool asks for an issue number, implying that trivial changes don't require a news entry. Please correct me if that's not the case.

@python-cla-bot
Copy link

python-cla-botbot commentedApr 30, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@methanemethane merged commit0119791 intopython:mainApr 30, 2025
41 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@methanemethanemethane approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@biglizards@methane@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp