Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-131531: Make Android build retry after network failures#133193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
freakboy3742 merged 1 commit intopython:mainfrommhsmith:android-retry
May 1, 2025

Conversation

mhsmith
Copy link
Member

@mhsmithmhsmith commentedApr 30, 2025•
edited
Loading

This commit was cherry-picked from#132870, because the buildbots have had a lot of intermittent download failures from GitHub URLs in the last few days.

It uses curl's--retry-all-errors flag, because some of the failures have returned codes that indicate a permanent failure (e.g. 403), even though it's actually temporary.

Other cleanups:

  • Useshutil.unpack_archive to remove the dependency on an externaltar command.
  • Clarify documentation and comments.

@mhsmith
Copy link
MemberAuthor

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@mhsmith for commit4c83a6b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133193%2Fmerge

The command will test the builders whose names match following regular expression:android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

Copy link
Contributor

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess time will tell whether 5 retries is enough. Otherwise, looks like a solid collection of cleanups.

@freakboy3742freakboy3742 merged commitfeac343 intopython:mainMay 1, 2025
51 checks passed
@miss-islington-app
Copy link

Thanks@mhsmith for the PR, and@freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 1, 2025
…honGH-133193)Adds a retry strategy when downloading compilation resources for Android, plus some other cleanups.(cherry picked from commitfeac343)Co-authored-by: Malcolm Smith <smith@chaquo.com>
@bedevere-app
Copy link

GH-133236 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 1, 2025
freakboy3742 pushed a commit that referenced this pull requestMay 1, 2025
…-133193) (#133236)Adds a retry strategy when downloading compilation resources for Android, plus some other cleanups.(cherry picked from commitfeac343)Co-authored-by: Malcolm Smith <smith@chaquo.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@freakboy3742freakboy3742freakboy3742 approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mhsmith@bedevere-bot@freakboy3742
[8]ページ先頭
©2009-2025 Movatter.jp